Re: [HACKERS] units in postgresql.conf comments

2014-01-11 Thread Josh Berkus
On 01/11/2014 11:06 AM, Bruce Momjian wrote: > On Wed, May 29, 2013 at 09:59:10PM -0400, Peter Eisentraut wrote: >> I think these sort of entries don't make much sense: >> >> #wal_sender_timeout = 60s # in milliseconds; 0 disables >> >> I think we should remove units from the comments when it'

Re: [HACKERS] units in postgresql.conf comments

2014-01-11 Thread Tom Lane
Bruce Momjian writes: > On Wed, May 29, 2013 at 09:59:10PM -0400, Peter Eisentraut wrote: >> I think these sort of entries don't make much sense: >> >> #wal_sender_timeout = 60s # in milliseconds; 0 disables >> >> I think we should remove units from the comments when it's clear from >> the

Re: [HACKERS] units in postgresql.conf comments

2014-01-11 Thread Bruce Momjian
On Wed, May 29, 2013 at 09:59:10PM -0400, Peter Eisentraut wrote: > I think these sort of entries don't make much sense: > > #wal_sender_timeout = 60s # in milliseconds; 0 disables > > I think we should remove units from the comments when it's clear from > the name or the default value that

Re: [HACKERS] units in postgresql.conf comments

2013-05-30 Thread Joshua D. Drake
On 05/30/2013 01:14 AM, Heikki Linnakangas wrote: On 30.05.2013 10:52, Joshua D. Drake wrote: On 05/30/2013 12:01 AM, Heikki Linnakangas wrote: We could make it mandatory to specify the unit in the value. Ie. throw an error on "wal_sender_timeout = 50": ERROR: unit required for option "wal_

Re: [HACKERS] units in postgresql.conf comments

2013-05-30 Thread Heikki Linnakangas
On 30.05.2013 10:52, Joshua D. Drake wrote: On 05/30/2013 12:01 AM, Heikki Linnakangas wrote: We could make it mandatory to specify the unit in the value. Ie. throw an error on "wal_sender_timeout = 50": ERROR: unit required for option "wal_sender_timeout" HINT: Valid units for this parameter

Re: [HACKERS] units in postgresql.conf comments

2013-05-30 Thread Joshua D. Drake
On 05/30/2013 12:55 AM, Magnus Hagander wrote: I like this idea with one addition. We should have a default unit for each. For wal_sender_timeout seconds makes sense, but for checkpoint_timeout minutes makes sense (for example). This sounds like a good way to make things even more confusing.

Re: [HACKERS] units in postgresql.conf comments

2013-05-30 Thread Magnus Hagander
On Thu, May 30, 2013 at 3:52 AM, Joshua D. Drake wrote: > > On 05/30/2013 12:01 AM, Heikki Linnakangas wrote: > >> We could make it mandatory to specify the unit in the value. Ie. throw >> an error on "wal_sender_timeout = 50": >> >> ERROR: unit required for option "wal_sender_timeout" >> HINT: V

Re: [HACKERS] units in postgresql.conf comments

2013-05-30 Thread Joshua D. Drake
On 05/30/2013 12:01 AM, Heikki Linnakangas wrote: We could make it mandatory to specify the unit in the value. Ie. throw an error on "wal_sender_timeout = 50": ERROR: unit required for option "wal_sender_timeout" HINT: Valid units for this parameter are "ms", "s", "min", "h", and "d". Then y

Re: [HACKERS] units in postgresql.conf comments

2013-05-30 Thread Heikki Linnakangas
On 30.05.2013 06:43, Bruce Momjian wrote: On Wed, May 29, 2013 at 09:59:10PM -0400, Peter Eisentraut wrote: I think these sort of entries don't make much sense: #wal_sender_timeout = 60s # in milliseconds; 0 disables I think we should remove units from the comments when it's clear from th

Re: [HACKERS] units in postgresql.conf comments

2013-05-29 Thread Bruce Momjian
On Wed, May 29, 2013 at 09:59:10PM -0400, Peter Eisentraut wrote: > I think these sort of entries don't make much sense: > > #wal_sender_timeout = 60s # in milliseconds; 0 disables > > I think we should remove units from the comments when it's clear from > the name or the default value that

[HACKERS] units in postgresql.conf comments

2013-05-29 Thread Peter Eisentraut
I think these sort of entries don't make much sense: #wal_sender_timeout = 60s # in milliseconds; 0 disables I think we should remove units from the comments when it's clear from the name or the default value that time units are accepted. -- Sent via pgsql-hackers mailing list (pgsql-hac