On tor, 2009-12-31 at 13:44 -0500, Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian writes:
> > > Tom Lane wrote:
> > >> BTW, it looks like the patch is showing a manual change to
> > >> pg_config.h.in. Don't do that. Run autoheader.
> >
> > > I wasn't aware autoheader existed. Is that
Tom Lane wrote:
> Bruce Momjian writes:
> > Tom Lane wrote:
> >> BTW, it looks like the patch is showing a manual change to
> >> pg_config.h.in. Don't do that. Run autoheader.
>
> > I wasn't aware autoheader existed. Is that new or has it alwasy been
> > part of autoconf?
>
> It's always been
Bruce Momjian writes:
> Tom Lane wrote:
>> BTW, it looks like the patch is showing a manual change to
>> pg_config.h.in. Don't do that. Run autoheader.
> I wasn't aware autoheader existed. Is that new or has it alwasy been
> part of autoconf?
It's always been there, or at least for many years
Tom Lane wrote:
> Magnus Hagander writes:
> > Attached patch is the part of the win64 patch that changes Datum to be
> > uintptr_t, and associated changes, with only very minor changes from
> > me. It also includes autoconf tests that I tricked Bruce into fixing
> > for me :-)
>
> > Comments?
>
2009/12/31 Tom Lane :
> Magnus Hagander writes:
>> 2009/12/31 Tom Lane :
>>> Where's the logic to provide a definition of
>>> intptr_t if the platform fails to?
>
>> autoconf does that.
>
> Oh, that's what I get for trying to review a patch before absorbing
> any caffeine :-( ... I missed that yo
Magnus Hagander writes:
> 2009/12/31 Tom Lane :
>> Where's the logic to provide a definition of
>> intptr_t if the platform fails to?
> autoconf does that.
Oh, that's what I get for trying to review a patch before absorbing
any caffeine :-( ... I missed that you were relying on a built-in
autoc
2009/12/31 Tom Lane :
> Magnus Hagander writes:
>> Attached patch is the part of the win64 patch that changes Datum to be
>> uintptr_t, and associated changes, with only very minor changes from
>> me. It also includes autoconf tests that I tricked Bruce into fixing
>> for me :-)
>
>> Comments?
>
>
Magnus Hagander writes:
> Attached patch is the part of the win64 patch that changes Datum to be
> uintptr_t, and associated changes, with only very minor changes from
> me. It also includes autoconf tests that I tricked Bruce into fixing
> for me :-)
> Comments?
This is a joke no? Where's the
Attached patch is the part of the win64 patch that changes Datum to be
uintptr_t, and associated changes, with only very minor changes from
me. It also includes autoconf tests that I tricked Bruce into fixing
for me :-)
Comments?
Unless there are objections, I'll go ahead and apply this one for
b
