Re: [HACKERS] tsvector work with citext

2015-09-21 Thread Teodor Sigaev
Fixed (9acb9007de30b3daaa9efc16763c3bc6e3e0a92d), but didn't backpatch because it isn't a critical bug. For those on older versions, whatтАЩs the simplest workaround? FWIW, I thought this would be a reasonable thing to back-patch. It's not as though contrib/citext hasn't been around for awhile.

Re: [HACKERS] tsvector work with citext

2015-09-18 Thread Tom Lane
"David E. Wheeler" writes: > On Sep 18, 2015, at 7:29 AM, Teodor Sigaev wrote: >> Fixed (9acb9007de30b3daaa9efc16763c3bc6e3e0a92d), but didn't backpatch >> because it isn't a critical bug. > Great, thank you! > For those on older versions, what’s the simplest workaround? FWIW, I thought this

Re: [HACKERS] tsvector work with citext

2015-09-18 Thread David E. Wheeler
On Sep 18, 2015, at 7:29 AM, Teodor Sigaev wrote: >> Fixable? > > Fixed (9acb9007de30b3daaa9efc16763c3bc6e3e0a92d), but didn't backpatch > because it isn't a critical bug. Great, thank you! For those on older versions, what’s the simplest workaround? Best, David -- Sent via pgsql-hacker

Re: [HACKERS] tsvector work with citext

2015-09-18 Thread Teodor Sigaev
Fixable? Fixed (9acb9007de30b3daaa9efc16763c3bc6e3e0a92d), but didn't backpatch because it isn't a critical bug. Thank you for the report! -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.r

Re: [HACKERS] tsvector work with citext

2015-09-17 Thread David E. Wheeler
On Sep 17, 2015, at 6:17 AM, Teodor Sigaev wrote: > I'm wrong, in this commit it was just renamed. It was originally coded by me. > But it's still oversight. Fixable? Thanks, David -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] tsvector work with citext

2015-09-17 Thread Teodor Sigaev
Oversight, I suppose. is_text_type() was introduced by commit 635aaab278afc1af972a4b6a55ff632ab763505d Author: Tom Lane Date: Tue Apr 8 18:20:29 2008 + Fix tsvector_update_trigger() to be domain-friendly: it needs to allow all the columns it works with to be domains over the exp

Re: [HACKERS] tsvector work with citext

2015-09-17 Thread Teodor Sigaev
However, it does seem like this function is not implementing its specification. Why isn't it just "IsBinaryCoercible(typid, TEXTOID)"? Oversight, I suppose. is_text_type() was introduced by commit 635aaab278afc1af972a4b6a55ff632ab763505d Author: Tom Lane Date: Tue Apr 8 18:20:29 2008 +

Re: [HACKERS] tsvector work with citext

2015-09-16 Thread Tom Lane
"David E. Wheeler" writes: > Is there a way to get tsvector_update_trigger() to work with citext > columns? Hmm ... tsvector_op.c has /* Check if datatype is TEXT or binary-equivalent to it */ static bool is_text_type(Oid typid) { /* varchar(n) and char(n) are binary-compatible with text

[HACKERS] tsvector work with citext

2015-09-16 Thread David E. Wheeler
Hey Hackers, Is there a way to get tsvector_update_trigger() to work with citext columns? The attached case throws an error: ERROR: column "title" is not of a character type Is the fact that citext is a (non-preferred) member of the string category not sufficient for this to work? If not,