Re: [HACKERS] test/example does not support win32.

2009-12-30 Thread Hiroshi Saito
Hi Tom-san. Ahh.. It was correction of the test of often... again, the pursued relation was seen, I think that it is good now. Thanks!! Regards, Hiroshi Saito - Original Message - From: "Tom Lane" "Hiroshi Saito" writes: [ examples_win32_patch2 ] Is the addition of -DFRONTEND

Re: [HACKERS] test/example does not support win32.

2009-12-30 Thread Tom Lane
"Hiroshi Saito" writes: > [ examples_win32_patch2 ] Is the addition of -DFRONTEND actually needed, and if so why? We shouldn't be depending on that in any user-exposed code, I would think. Otherwise I don't have any objection to this version. regards, tom lane -- Sent

Re: [HACKERS] test/example does not support win32.

2009-12-30 Thread Magnus Hagander
2009/12/30 Hiroshi Saito : > Hi Andrew-san. > > This saves a windows users. > I appreciate your suggestion. > Thanks! This one looks much better. +1 for this version :-) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing li

Re: [HACKERS] test/example does not support win32.

2009-12-30 Thread Hiroshi Saito
Hi Andrew-san. This saves a windows users. I appreciate your suggestion. Thanks! P.S) I often use by the test by nmake at the time of independent creation of libpq. Regards, Hiroshi Saito - Original Message - From: "Andrew Dunstan" Hiroshi Saito wrote: Hi Andrew-san. Althou

Re: [HACKERS] test/example does not support win32.

2009-12-30 Thread Tom Lane
Andrew Dunstan writes: > Tom Lane wrote: >> On reflection I think it's just wrong to expect that the examples will >> compile out-of-the-box on every platform. > That would be all good and well if we didn't already rely on the > configure setup. But we do - the Makefile includes src/Makefile.glo

Re: [HACKERS] test/example does not support win32.

2009-12-30 Thread Andrew Dunstan
Hiroshi Saito wrote: Hi Andrew-san. Although this is a standard in windows. *** testlibpq2.c.orig Wed Dec 30 13:19:03 2009 --- testlibpq2.cThu Dec 31 00:52:52 2009 *** *** 24,34 --- 24,39 * * INSERT INTO TBL1 VALUES (10); */ + + #ifdef WIN32 + #includ

Re: [HACKERS] test/example does not support win32.

2009-12-30 Thread Hiroshi Saito
uot; Cc: "Hiroshi Saito" ; "Alvaro Herrera" ; "pgsql-hackers" ; "Bruce Momjian" Sent: Thursday, December 31, 2009 12:45 AM Subject: Re: [HACKERS] test/example does not support win32. Tom Lane wrote: "Hiroshi Saito" writes: Yes, I thi

Re: [HACKERS] test/example does not support win32.

2009-12-30 Thread Andrew Dunstan
Tom Lane wrote: "Hiroshi Saito" writes: Yes, I thinks that it is an exact idea. However, this example was not helped. fd_set complains Thanks! It seems that pg_bench takes the thing same again into consideration. Anyway, If it is called example of end-user code, what is th

Re: [HACKERS] test/example does not support win32.

2009-12-30 Thread Tom Lane
Bruce Momjian writes: > Well, those example programs are pretty clean libpq apps so I don't see > why they should using platform-specific stuff. Example #2 depends on select(), which depends on fd_set, so you're already into territory where there are issues. regards, tom

Re: [HACKERS] test/example does not support win32.

2009-12-30 Thread Bruce Momjian
Tom Lane wrote: > "Hiroshi Saito" writes: > > Yes, I thinks that it is an exact idea. However, this example was not > > helped. > > fd_set complains > > Thanks! > > > It seems that pg_bench takes the thing same again into consideration. > > Anyway, If it is called example of end-user cod

Re: [HACKERS] test/example does not support win32.

2009-12-30 Thread Tom Lane
"Hiroshi Saito" writes: > Yes, I thinks that it is an exact idea. However, this example was not helped. > fd_set complains > Thanks! > It seems that pg_bench takes the thing same again into consideration. > Anyway, If it is called example of end-user code, what is the evasion method > of

Re: [HACKERS] test/example does not support win32.

2009-12-30 Thread Hiroshi Saito
Hi Alvaro-san. Yes, I thinks that it is an exact idea. However, this example was not helped. fd_set complains Thanks! It seems that pg_bench takes the thing same again into consideration. Anyway, If it is called example of end-user code, what is the evasion method of fd_set? Regards,

Re: [HACKERS] test/example does not support win32.

2009-12-30 Thread Alvaro Herrera
Hiroshi Saito wrote: > Hi Tom-san. > > Um, How do you consider sample which cannot build? I think testlibpq2.c is missing a couple of system includes, sys/types.h and unistd.h (or alternatively select.h); and testlibpq3.c is missing stdint.h. Or so say my (POSIX) manpages anyway. -- Alvaro Her

Re: [HACKERS] test/example does not support win32.

2009-12-29 Thread Hiroshi Saito
Hi Tom-san. Um, How do you consider sample which cannot build? Regards, Hiroshi Saito - Original Message - From: "Tom Lane" "Hiroshi Saito" writes: test/example does not support win32. The proposed added #includes seem quite inappropriate. postgres_fe.h is meant for PG-proj

Re: [HACKERS] test/example does not support win32.

2009-12-29 Thread Tom Lane
"Hiroshi Saito" writes: > test/example does not support win32. The proposed added #includes seem quite inappropriate. postgres_fe.h is meant for PG-project code, it is not supposed to have to be included by all end-user code. regards, tom lane -- Sent via pgsql-hackers

[HACKERS] test/example does not support win32.

2009-12-29 Thread Hiroshi Saito
Hi. test/example does not support win32. Although I posted also in the past, I am slightly persistent. I think whether it also needs correction of a document. == CVS-HEAD on as for MinGW + gcc == testlibpq2.c: In function `main': testlibpq2.c:98: error: `fd_set' undeclared (first use in this