Re: [HACKERS] suspicous looking code in copy.c

2003-08-28 Thread Tom Lane
Andreas Pflug <[EMAIL PROTECTED]> writes: >> shouldn't it be datasize -= avail ? >> > AFAIR this is a really outdated K&R style of -= . Compilers *should* > recognize this (and will throw an ambiguity error if there's no space > after =- ), but it's better to use the 'newer' style. Dave didn't

Re: [HACKERS] suspicous looking code in copy.c

2003-08-28 Thread Tom Lane
Dave Cramer <[EMAIL PROTECTED]> writes: > This just doesn't look right. Ugh, you're right. regards, tom lane ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [HACKERS] suspicous looking code in copy.c

2003-08-28 Thread Dave Cramer
Well, it get's worse, I think after bruce ran pgindent it was turned into datasize = -avail; Dave On Thu, 2003-08-28 at 08:19, Andreas Pflug wrote: > Dave Cramer wrote: > > >This just doesn't look right. > > > >line 364 > >case COPY_NEW_FE: > > > > while (da

Re: [HACKERS] suspicous looking code in copy.c

2003-08-28 Thread Andreas Pflug
Dave Cramer wrote: This just doesn't look right. line 364 case COPY_NEW_FE: while (datasize > 0 && !fe_eof) line 408 datasize =- avail; shouldn't it be datasize -= avail ? AFAIR this is a really outdated K&R style of -= . Comp

[HACKERS] suspicous looking code in copy.c

2003-08-28 Thread Dave Cramer
This just doesn't look right. line 364 case COPY_NEW_FE: while (datasize > 0 && !fe_eof) line 408datasize =- avail; shouldn't it be datasize -= avail ? Dave -- Dave Cramer <[EMAIL