Re: [HACKERS] subscription worker doesn't start immediately on eabled

2017-05-07 Thread Masahiko Sawada
On Tue, May 2, 2017 at 11:53 AM, Peter Eisentraut wrote: > On 4/27/17 21:36, Masahiko Sawada wrote: >> That makes sense to me. Since NOCONNECT option changes some default >> values including ENABLED to false I think we should apply it also when >> NOCONNECT is specified? > > That's not necessary,

Re: [HACKERS] subscription worker doesn't start immediately on eabled

2017-05-01 Thread Peter Eisentraut
On 4/26/17 11:51, Fujii Masao wrote: > On Wed, Apr 26, 2017 at 4:03 PM, Kyotaro HORIGUCHI > wrote: >> At Tue, 25 Apr 2017 14:45:03 -0400, Peter Eisentraut >> wrote in >> <3d6a1bd0-08ce-301d-3336-ec9f623a3...@2ndquadrant.com> >>> On 4/6/17 08:24, Kyotaro HORIGUCHI wrote: The attached patch

Re: [HACKERS] subscription worker doesn't start immediately on eabled

2017-05-01 Thread Peter Eisentraut
On 4/27/17 21:36, Masahiko Sawada wrote: > That makes sense to me. Since NOCONNECT option changes some default > values including ENABLED to false I think we should apply it also when > NOCONNECT is specified? That's not necessary, because if NOCONNECT is specified, then "enabled" will be set acco

Re: [HACKERS] subscription worker doesn't start immediately on eabled

2017-04-28 Thread Kyotaro HORIGUCHI
At Fri, 28 Apr 2017 06:43:19 +0900, Fujii Masao wrote in > On Thu, Apr 27, 2017 at 6:32 PM, Kyotaro HORIGUCHI > wrote: > > At Thu, 27 Apr 2017 00:51:03 +0900, Fujii Masao > > wrote in > > > >> On Wed, Apr 26, 2017 at 4:03 PM, Kyotaro HORIGUCHI > >> wrote: > >> > At Tue, 25 Apr 2017 14:45:0

Re: [HACKERS] subscription worker doesn't start immediately on eabled

2017-04-27 Thread Masahiko Sawada
On Thu, Apr 27, 2017 at 12:51 AM, Fujii Masao wrote: > On Wed, Apr 26, 2017 at 4:03 PM, Kyotaro HORIGUCHI > wrote: >> At Tue, 25 Apr 2017 14:45:03 -0400, Peter Eisentraut >> wrote in >> <3d6a1bd0-08ce-301d-3336-ec9f623a3...@2ndquadrant.com> >>> On 4/6/17 08:24, Kyotaro HORIGUCHI wrote: >>> > T

Re: [HACKERS] subscription worker doesn't start immediately on eabled

2017-04-27 Thread Fujii Masao
On Thu, Apr 27, 2017 at 6:32 PM, Kyotaro HORIGUCHI wrote: > At Thu, 27 Apr 2017 00:51:03 +0900, Fujii Masao wrote > in >> On Wed, Apr 26, 2017 at 4:03 PM, Kyotaro HORIGUCHI >> wrote: >> > At Tue, 25 Apr 2017 14:45:03 -0400, Peter Eisentraut >> > wrote in >> > <3d6a1bd0-08ce-301d-3336-ec9f62

Re: [HACKERS] subscription worker doesn't start immediately on eabled

2017-04-27 Thread Kyotaro HORIGUCHI
At Thu, 27 Apr 2017 00:51:03 +0900, Fujii Masao wrote in > On Wed, Apr 26, 2017 at 4:03 PM, Kyotaro HORIGUCHI > wrote: > > At Tue, 25 Apr 2017 14:45:03 -0400, Peter Eisentraut > > wrote in > > <3d6a1bd0-08ce-301d-3336-ec9f623a3...@2ndquadrant.com> > >> On 4/6/17 08:24, Kyotaro HORIGUCHI wrot

Re: [HACKERS] subscription worker doesn't start immediately on eabled

2017-04-26 Thread Fujii Masao
On Wed, Apr 26, 2017 at 4:03 PM, Kyotaro HORIGUCHI wrote: > At Tue, 25 Apr 2017 14:45:03 -0400, Peter Eisentraut > wrote in > <3d6a1bd0-08ce-301d-3336-ec9f623a3...@2ndquadrant.com> >> On 4/6/17 08:24, Kyotaro HORIGUCHI wrote: >> > The attached patch wakes up launcher when a subscription is >> >

Re: [HACKERS] subscription worker doesn't start immediately on eabled

2017-04-26 Thread Kyotaro HORIGUCHI
At Tue, 25 Apr 2017 14:45:03 -0400, Peter Eisentraut wrote in <3d6a1bd0-08ce-301d-3336-ec9f623a3...@2ndquadrant.com> > On 4/6/17 08:24, Kyotaro HORIGUCHI wrote: > > The attached patch wakes up launcher when a subscription is > > enabled. This fails when a subscription is enabled immedaitely > >

Re: [HACKERS] subscription worker doesn't start immediately on eabled

2017-04-25 Thread Peter Eisentraut
On 4/6/17 08:24, Kyotaro HORIGUCHI wrote: > The attached patch wakes up launcher when a subscription is > enabled. This fails when a subscription is enabled immedaitely > after disabling but it won't be a matter. committed, thanks -- Peter Eisentraut http://www.2ndQuadrant.com/ Post

Re: [HACKERS] subscription worker doesn't start immediately on eabled

2017-04-24 Thread Kyotaro HORIGUCHI
Hello, At Fri, 21 Apr 2017 10:15:20 -0400, Peter Eisentraut wrote in <77f75a90-a495-6661-68df-e4993bfac...@2ndquadrant.com> > On 4/6/17 08:24, Kyotaro HORIGUCHI wrote: > > Hello. I found dubious behavior while playing with logical > > replication. > > > > When we disable a subscription, replic

Re: [HACKERS] subscription worker doesn't start immediately on eabled

2017-04-21 Thread Peter Eisentraut
On 4/6/17 08:24, Kyotaro HORIGUCHI wrote: > Hello. I found dubious behavior while playing with logical > replication. > > When we disable a subscription, replication worker immediately stops. > > =# ALTER SUBSCRIPTION s1 DISABLE; > > On the other hand even if we enable a subscription, worker > d

Re: [HACKERS] subscription worker doesn't start immediately on eabled

2017-04-06 Thread Petr Jelinek
On 06/04/17 14:24, Kyotaro HORIGUCHI wrote: > Hello. I found dubious behavior while playing with logical > replication. > > When we disable a subscription, replication worker immediately stops. > > =# ALTER SUBSCRIPTION s1 DISABLE; > > On the other hand even if we enable a subscription, worker >

[HACKERS] subscription worker doesn't start immediately on eabled

2017-04-06 Thread Kyotaro HORIGUCHI
Hello. I found dubious behavior while playing with logical replication. When we disable a subscription, replication worker immediately stops. =# ALTER SUBSCRIPTION s1 DISABLE; On the other hand even if we enable a subscription, worker doesn't start immediately. It takes 3 minutes in the worst ca