Re: [HACKERS] static-if-inline

2012-10-08 Thread Tom Lane
Alvaro Herrera writes: > What's being done in this patch is exactly what would be done in the > ilist code. So if there are problems with this, please speak up. Stylistic gripe: in palloc.h you didn't follow the pattern of #ifndef USE_INLINE extern ... #endif before (rath

[HACKERS] static-if-inline

2012-10-08 Thread Alvaro Herrera
The ilist patch from Andres Freund introduces a cute trick for defining maybe-inline functions, which works regardless of whether the compiler supports inlining, and eliminates the need to write the code twice (first in the header and also the .c file.) It's really quite a simple thing, but the wh