Re: [HACKERS] splitting plpython into smaller parts

2011-12-18 Thread Jan Urbański
On 18/12/11 20:53, Peter Eisentraut wrote: > On tis, 2011-12-06 at 00:58 +0100, Jan Urbański wrote: >> Rebased against master after the SPI cursor patch has been committed. >> >> The first patch removes SPI boilerplate from the cursor functions as >> well and the second patch creates a plpython_cur

Re: [HACKERS] splitting plpython into smaller parts

2011-12-18 Thread Peter Eisentraut
On tis, 2011-12-06 at 00:58 +0100, Jan Urbański wrote: > Rebased against master after the SPI cursor patch has been committed. > > The first patch removes SPI boilerplate from the cursor functions as > well and the second patch creates a plpython_cursor.c file. > > A side effect of creating a sep

Re: [HACKERS] splitting plpython into smaller parts

2011-12-15 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Peter Eisentraut's message of jue dic 15 12:00:13 -0300 2011: >> How to people feel about naming the files (as proposed) >> >> ! OBJS = plpython.o plpython_io.o plpython_procedure.o plpython_exec.o \ >> !plpython_plpy.o plpython_spi.o plpython_result

Re: [HACKERS] splitting plpython into smaller parts

2011-12-15 Thread Alvaro Herrera
Excerpts from Peter Eisentraut's message of jue dic 15 12:00:13 -0300 2011: > How to people feel about naming the files (as proposed) > > ! OBJS = plpython.o plpython_io.o plpython_procedure.o plpython_exec.o \ > !plpython_plpy.o plpython_spi.o plpython_result.o plpython_cursor.o \ > !

Re: [HACKERS] splitting plpython into smaller parts

2011-12-15 Thread Peter Eisentraut
How to people feel about naming the files (as proposed) ! OBJS = plpython.o plpython_io.o plpython_procedure.o plpython_exec.o \ !plpython_plpy.o plpython_spi.o plpython_result.o plpython_cursor.o \ !plpython_plan.o plpython_subtransaction.o plpython_functions.o \ !plpython

Re: [HACKERS] splitting plpython into smaller parts

2011-11-28 Thread Peter Eisentraut
On mån, 2011-11-28 at 02:00 -0800, Greg Smith wrote: > On 11/13/2011 09:45 AM, Jan Urbański wrote: > > The first one factors out some bolerplate related to executing SPI > > functions in subtransactions (and idea borrowed from pltcl.c). > > While I haven't looked at the code, this seems worthwhil

Re: [HACKERS] splitting plpython into smaller parts

2011-11-28 Thread Jan Urbański
On 28/11/11 11:00, Greg Smith wrote: On 11/13/2011 09:45 AM, Jan Urbański wrote: The second one is the actual split. plpython.c has been split into 11 separate files and one header. Could you comment a bit more about what the goal of this is? We don't have a reviewer for this patch yet, and I

Re: [HACKERS] splitting plpython into smaller parts

2011-11-28 Thread Greg Smith
On 11/13/2011 09:45 AM, Jan Urbański wrote: The first one factors out some bolerplate related to executing SPI functions in subtransactions (and idea borrowed from pltcl.c). While I haven't looked at the code, this seems worthwhile from the description. The second one is the actual split. pl