On 4/29/17 00:33, Noah Misch wrote:
> On Fri, Apr 28, 2017 at 02:13:48PM -0400, Peter Eisentraut wrote:
>> On 4/28/17 01:01, Noah Misch wrote:
>>> On Fri, Apr 28, 2017 at 01:55:48PM +0900, Masahiko Sawada wrote:
On Fri, Apr 28, 2017 at 1:42 PM, Noah Misch wrote:
> On Fri, Apr 28, 2017 at
I have committed this version.
I have omitted all the talk about 2PC. There are discussions ongoing
about changing the transaction behavior of CREATE SUBSCRIPTION, which
might interfere with that. If someone wants to rebase and propose the
parts about 2PC separately, I don't object, but it can b
On Sat, Apr 29, 2017 at 12:33 AM, Noah Misch wrote:
>> I think the patch that Fujii Masao has proposed has found general
>> agreement. I would recommend that he commits it as he sees fit.
>
> This is not a conforming status update, because it does not specify a date for
> your next update.
If Pe
On Fri, Apr 28, 2017 at 02:13:48PM -0400, Peter Eisentraut wrote:
> On 4/28/17 01:01, Noah Misch wrote:
> > On Fri, Apr 28, 2017 at 01:55:48PM +0900, Masahiko Sawada wrote:
> >> On Fri, Apr 28, 2017 at 1:42 PM, Noah Misch wrote:
> >>> On Fri, Apr 28, 2017 at 06:37:09AM +0900, Fujii Masao wrote:
>
On 4/28/17 01:01, Noah Misch wrote:
> On Fri, Apr 28, 2017 at 01:55:48PM +0900, Masahiko Sawada wrote:
>> On Fri, Apr 28, 2017 at 1:42 PM, Noah Misch wrote:
>>> On Fri, Apr 28, 2017 at 06:37:09AM +0900, Fujii Masao wrote:
Pushed. Thanks!
>>>
>>> Does this close the open item, or is there more
On Fri, Apr 28, 2017 at 01:55:48PM +0900, Masahiko Sawada wrote:
> On Fri, Apr 28, 2017 at 1:42 PM, Noah Misch wrote:
> > On Fri, Apr 28, 2017 at 06:37:09AM +0900, Fujii Masao wrote:
> >> Pushed. Thanks!
> >
> > Does this close the open item, or is there more to do?
>
> There is only one item rem
On Fri, Apr 28, 2017 at 1:42 PM, Noah Misch wrote:
> On Fri, Apr 28, 2017 at 06:37:09AM +0900, Fujii Masao wrote:
>> Pushed. Thanks!
>
> Does this close the open item, or is there more to do?
There is only one item remaining, and the patch is attached on
here[1]. I guess reviewing that patch is a
On Fri, Apr 28, 2017 at 06:37:09AM +0900, Fujii Masao wrote:
> Pushed. Thanks!
Does this close the open item, or is there more to do?
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Thu, Apr 27, 2017 at 5:37 PM, Petr Jelinek
wrote:
> On 26/04/17 18:36, Fujii Masao wrote:
>> On Thu, Apr 27, 2017 at 1:28 AM, Fujii Masao wrote:
>>> On Wed, Apr 26, 2017 at 3:47 PM, Kyotaro HORIGUCHI
>>> wrote:
At Wed, 26 Apr 2017 14:31:12 +0900, Masahiko Sawada
wrote in
>>
On 26/04/17 18:36, Fujii Masao wrote:
> On Thu, Apr 27, 2017 at 1:28 AM, Fujii Masao wrote:
>> On Wed, Apr 26, 2017 at 3:47 PM, Kyotaro HORIGUCHI
>> wrote:
>>> At Wed, 26 Apr 2017 14:31:12 +0900, Masahiko Sawada
>>> wrote in
>>>
On Wed, Apr 26, 2017 at 12:35 PM, Petr Jelinek
wrote:
On Thu, Apr 27, 2017 at 1:28 AM, Fujii Masao wrote:
> On Wed, Apr 26, 2017 at 3:47 PM, Kyotaro HORIGUCHI
> wrote:
>> At Wed, 26 Apr 2017 14:31:12 +0900, Masahiko Sawada
>> wrote in
>>
>>> On Wed, Apr 26, 2017 at 12:35 PM, Petr Jelinek
>>> wrote:
>>> > On 26/04/17 01:01, Fujii Masao wrote:
>>
On Wed, Apr 26, 2017 at 3:47 PM, Kyotaro HORIGUCHI
wrote:
> At Wed, 26 Apr 2017 14:31:12 +0900, Masahiko Sawada
> wrote in
>
>> On Wed, Apr 26, 2017 at 12:35 PM, Petr Jelinek
>> wrote:
>> > On 26/04/17 01:01, Fujii Masao wrote:
>> However this is overkill for small gain and false wakeup
At Wed, 26 Apr 2017 14:31:12 +0900, Masahiko Sawada
wrote in
> On Wed, Apr 26, 2017 at 12:35 PM, Petr Jelinek
> wrote:
> > On 26/04/17 01:01, Fujii Masao wrote:
> However this is overkill for small gain and false wakeup of the
> launcher is not so harmful (probably we can live with th
On Wed, Apr 26, 2017 at 12:35 PM, Petr Jelinek
wrote:
> On 26/04/17 01:01, Fujii Masao wrote:
>> On Mon, Apr 24, 2017 at 7:57 PM, Kyotaro HORIGUCHI
>> wrote:
>>> Hello,
>>>
>>> At Mon, 24 Apr 2017 11:18:32 +0900, Masahiko Sawada
>>> wrote in
>>>
>> BEGIN;
>> ALTER SUBSCRIPTION hoge_su
On 26/04/17 01:01, Fujii Masao wrote:
> On Mon, Apr 24, 2017 at 7:57 PM, Kyotaro HORIGUCHI
> wrote:
>> Hello,
>>
>> At Mon, 24 Apr 2017 11:18:32 +0900, Masahiko Sawada
>> wrote in
> BEGIN;
> ALTER SUBSCRIPTION hoge_sub ENABLE;
> PREPARE TRANSACTION 'g';
> BEGIN;
> SELECT 1;
On Mon, Apr 24, 2017 at 7:57 PM, Kyotaro HORIGUCHI
wrote:
> Hello,
>
> At Mon, 24 Apr 2017 11:18:32 +0900, Masahiko Sawada
> wrote in
>> >> BEGIN;
>> >> ALTER SUBSCRIPTION hoge_sub ENABLE;
>> >> PREPARE TRANSACTION 'g';
>> >> BEGIN;
>> >> SELECT 1;
>> >> COMMIT; -- wake up the launcher at this
At Tue, 25 Apr 2017 10:11:06 +0900, Masahiko Sawada
wrote in
> On Mon, Apr 24, 2017 at 7:57 PM, Kyotaro HORIGUCHI
> wrote:
> > Hello,
> >
> > At Mon, 24 Apr 2017 11:18:32 +0900, Masahiko Sawada
> > wrote in
> >
> >> >> BEGIN;
> >> >> ALTER SUBSCRIPTION hoge_sub ENABLE;
> >> >> PREPARE TRANS
On Mon, Apr 24, 2017 at 7:57 PM, Kyotaro HORIGUCHI
wrote:
> Hello,
>
> At Mon, 24 Apr 2017 11:18:32 +0900, Masahiko Sawada
> wrote in
>> >> BEGIN;
>> >> ALTER SUBSCRIPTION hoge_sub ENABLE;
>> >> PREPARE TRANSACTION 'g';
>> >> BEGIN;
>> >> SELECT 1;
>> >> COMMIT; -- wake up the launcher at this
Hello,
At Mon, 24 Apr 2017 11:18:32 +0900, Masahiko Sawada
wrote in
> >> BEGIN;
> >> ALTER SUBSCRIPTION hoge_sub ENABLE;
> >> PREPARE TRANSACTION 'g';
> >> BEGIN;
> >> SELECT 1;
> >> COMMIT; -- wake up the launcher at this point.
> >> COMMIT PREPARED 'g';
> >>
> >> Even if we wake up the launc
On Sat, Apr 22, 2017 at 4:26 AM, Fujii Masao wrote:
> On Fri, Apr 21, 2017 at 4:02 PM, Masahiko Sawada
> wrote:
>> On Fri, Apr 21, 2017 at 1:19 AM, Fujii Masao wrote:
>>> On Tue, Apr 18, 2017 at 5:16 PM, Masahiko Sawada
>>> wrote:
On Tue, Apr 18, 2017 at 12:24 PM, Kyotaro HORIGUCHI
On Fri, Apr 21, 2017 at 4:02 PM, Masahiko Sawada wrote:
> On Fri, Apr 21, 2017 at 1:19 AM, Fujii Masao wrote:
>> On Tue, Apr 18, 2017 at 5:16 PM, Masahiko Sawada
>> wrote:
>>> On Tue, Apr 18, 2017 at 12:24 PM, Kyotaro HORIGUCHI
>>> wrote:
Hi,
Thank you for the revised version.
>
On Fri, Apr 21, 2017 at 11:55 AM, Masahiko Sawada wrote:
> On Fri, Apr 21, 2017 at 4:41 AM, Peter Eisentraut
> wrote:
>> On 4/20/17 12:30, Fujii Masao wrote:
>>> I've pushed several patches, and there is now only one remaining patch.
>>> I posted the review comment on that patch, and I'm expectin
On Fri, Apr 21, 2017 at 1:19 AM, Fujii Masao wrote:
> On Tue, Apr 18, 2017 at 5:16 PM, Masahiko Sawada
> wrote:
>> On Tue, Apr 18, 2017 at 12:24 PM, Kyotaro HORIGUCHI
>> wrote:
>>> Hi,
>>>
>>> Thank you for the revised version.
>>>
>>> At Mon, 17 Apr 2017 23:29:28 +0900, Masahiko Sawada
>>> w
At Wed, 19 Apr 2017 10:59:00 +0200, Petr Jelinek
wrote in <3ef9c831-0508-51a9-5ded-c2e31e958...@2ndquadrant.com>
> On 19/04/17 10:45, Kyotaro HORIGUCHI wrote:
> > At Wed, 19 Apr 2017 17:43:17 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI
> > wrote in
> > <20170419.174317.114509231.horiguchi.k
On Fri, Apr 21, 2017 at 4:41 AM, Peter Eisentraut
wrote:
> On 4/20/17 12:30, Fujii Masao wrote:
>> I've pushed several patches, and there is now only one remaining patch.
>> I posted the review comment on that patch, and I'm expecting that
>> Masahiko-san will update the patch. So what about waiti
On 4/20/17 12:30, Fujii Masao wrote:
> I've pushed several patches, and there is now only one remaining patch.
> I posted the review comment on that patch, and I'm expecting that
> Masahiko-san will update the patch. So what about waiting for the updated
> version of the patch by next Monday (April
On Thu, Apr 20, 2017 at 12:05 PM, Noah Misch wrote:
> On Sun, Apr 16, 2017 at 06:14:49AM +, Noah Misch wrote:
>> On Fri, Apr 14, 2017 at 04:47:12AM +0900, Fujii Masao wrote:
>> > Though I've read only a part of the logical rep code yet, I'd like to
>> > share some (relatively minor) review com
On Tue, Apr 18, 2017 at 5:16 PM, Masahiko Sawada wrote:
> On Tue, Apr 18, 2017 at 12:24 PM, Kyotaro HORIGUCHI
> wrote:
>> Hi,
>>
>> Thank you for the revised version.
>>
>> At Mon, 17 Apr 2017 23:29:28 +0900, Masahiko Sawada
>> wrote in
>>> On Mon, Apr 17, 2017 at 9:13 PM, Masahiko Sawada
>>
On Sun, Apr 16, 2017 at 06:14:49AM +, Noah Misch wrote:
> On Fri, Apr 14, 2017 at 04:47:12AM +0900, Fujii Masao wrote:
> > Though I've read only a part of the logical rep code yet, I'd like to
> > share some (relatively minor) review comments that I got so far.
> >
> > In ApplyWorkerMain(), Da
On 19/04/17 10:45, Kyotaro HORIGUCHI wrote:
> At Wed, 19 Apr 2017 17:43:17 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI
> wrote in
> <20170419.174317.114509231.horiguchi.kyot...@lab.ntt.co.jp>
>> At Wed, 19 Apr 2017 10:33:29 +0200, Petr Jelinek
>> wrote in
>>
Commit has been moved fro
At Wed, 19 Apr 2017 17:43:17 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI
wrote in
<20170419.174317.114509231.horiguchi.kyot...@lab.ntt.co.jp>
> At Wed, 19 Apr 2017 10:33:29 +0200, Petr Jelinek
> wrote in
>
> > > Commit has been moved from after to before of the lock section.
> > > This ca
At Wed, 19 Apr 2017 10:33:29 +0200, Petr Jelinek
wrote in
> > Commit has been moved from after to before of the lock section.
> > This causes potential race condition. (As the same as the
> > potential dead-lock, I'm not sure it can cause realistic problem,
> > though..) Isn't it better to be af
On 19/04/17 10:25, Kyotaro HORIGUCHI wrote:
> At Wed, 19 Apr 2017 04:18:18 +0200, Petr Jelinek
> wrote in
>
>> On 18/04/17 19:27, Fujii Masao wrote:
>>> On Wed, Apr 19, 2017 at 1:35 AM, Petr Jelinek
>>> wrote:
Thank you for working on this!
On 18/04/17 10:16, Masahiko Sawada wro
At Wed, 19 Apr 2017 04:18:18 +0200, Petr Jelinek
wrote in
> On 18/04/17 19:27, Fujii Masao wrote:
> > On Wed, Apr 19, 2017 at 1:35 AM, Petr Jelinek
> > wrote:
> >> Thank you for working on this!
> >>
> >> On 18/04/17 10:16, Masahiko Sawada wrote:
> >>> On Tue, Apr 18, 2017 at 12:24 PM, Kyotaro
On 18/04/17 19:27, Fujii Masao wrote:
> On Wed, Apr 19, 2017 at 1:35 AM, Petr Jelinek
> wrote:
>> Thank you for working on this!
>>
>> On 18/04/17 10:16, Masahiko Sawada wrote:
>>> On Tue, Apr 18, 2017 at 12:24 PM, Kyotaro HORIGUCHI
>>> wrote:
>>
10.
>
> SpinLockA
On Wed, Apr 19, 2017 at 1:35 AM, Petr Jelinek
wrote:
> Thank you for working on this!
>
> On 18/04/17 10:16, Masahiko Sawada wrote:
>> On Tue, Apr 18, 2017 at 12:24 PM, Kyotaro HORIGUCHI
>> wrote:
>>>
>>> 3.
ApplyLauncherWakeup() should be static function.
>>>
>>> At
Thank you for working on this!
On 18/04/17 10:16, Masahiko Sawada wrote:
> On Tue, Apr 18, 2017 at 12:24 PM, Kyotaro HORIGUCHI
> wrote:
>>
>> 3.
>>>
>>> ApplyLauncherWakeup() should be static function.
>>
>> Attached 003 patch fixes it (and also fixes #5 review comment).
>
On Tue, Apr 18, 2017 at 12:24 PM, Kyotaro HORIGUCHI
wrote:
> Hi,
>
> Thank you for the revised version.
>
> At Mon, 17 Apr 2017 23:29:28 +0900, Masahiko Sawada
> wrote in
>> On Mon, Apr 17, 2017 at 9:13 PM, Masahiko Sawada
>> wrote:
>> > On Mon, Apr 17, 2017 at 7:39 PM, Kyotaro HORIGUCHI
>> >
Hi,
Thank you for the revised version.
At Mon, 17 Apr 2017 23:29:28 +0900, Masahiko Sawada
wrote in
> On Mon, Apr 17, 2017 at 9:13 PM, Masahiko Sawada
> wrote:
> > On Mon, Apr 17, 2017 at 7:39 PM, Kyotaro HORIGUCHI
> > wrote:
> >> At Mon, 17 Apr 2017 18:02:57 +0900, Masahiko Sawada
> >> w
On Mon, Apr 17, 2017 at 9:13 PM, Masahiko Sawada wrote:
> On Mon, Apr 17, 2017 at 7:39 PM, Kyotaro HORIGUCHI
> wrote:
>> At Mon, 17 Apr 2017 18:02:57 +0900, Masahiko Sawada
>> wrote in
>>> On Fri, Apr 14, 2017 at 4:47 AM, Fujii Masao wrote:
>>> > Hi,
>>> >
>>> > Though I've read only a part o
On Mon, Apr 17, 2017 at 7:39 PM, Kyotaro HORIGUCHI
wrote:
> At Mon, 17 Apr 2017 18:02:57 +0900, Masahiko Sawada
> wrote in
>> On Fri, Apr 14, 2017 at 4:47 AM, Fujii Masao wrote:
>> > Hi,
>> >
>> > Though I've read only a part of the logical rep code yet, I'd like to
>> > share some (relatively
At Mon, 17 Apr 2017 18:02:57 +0900, Masahiko Sawada
wrote in
> On Fri, Apr 14, 2017 at 4:47 AM, Fujii Masao wrote:
> > Hi,
> >
> > Though I've read only a part of the logical rep code yet, I'd like to
> > share some (relatively minor) review comments that I got so far.
>
> It seems nobody is w
On Fri, Apr 14, 2017 at 4:47 AM, Fujii Masao wrote:
> Hi,
>
> Though I've read only a part of the logical rep code yet, I'd like to
> share some (relatively minor) review comments that I got so far.
It seems nobody is working on dealing with these review comments, so
I've attached patches. Since
On Fri, Apr 14, 2017 at 04:47:12AM +0900, Fujii Masao wrote:
> Though I've read only a part of the logical rep code yet, I'd like to
> share some (relatively minor) review comments that I got so far.
>
> In ApplyWorkerMain(), DatumGetInt32() should be used to get integer
> value from the argument,
Hi,
Though I've read only a part of the logical rep code yet, I'd like to
share some (relatively minor) review comments that I got so far.
In ApplyWorkerMain(), DatumGetInt32() should be used to get integer
value from the argument, instead of DatumGetObjectId().
No one resets on_commit_launcher_
45 matches
Mail list logo
