Re: [HACKERS] small makeVar refactoring

2010-08-21 Thread Tom Lane
Peter Eisentraut writes: > While hacking around, I noticed that a lot of makeVar() calls could be > refactored into some convenience functions, to save some redundancy and > so that the unusual call patterns stand out better. Useful? I'm not real thrilled with importing catalog/pg_attribute.h in

[HACKERS] small makeVar refactoring

2010-08-21 Thread Peter Eisentraut
While hacking around, I noticed that a lot of makeVar() calls could be refactored into some convenience functions, to save some redundancy and so that the unusual call patterns stand out better. Useful? Index: src/backend/commands/tablecmds.c ===