Re: [HACKERS] shall we have a TRACE_MEMORY mode

2006-06-22 Thread korry
> As I follow Relyea Mike's recent post of possible memory leak, I think that > we are lack of a good way of identifing memory usage. Maybe we should also > remember __FILE__, __LINE__ etc for better memory usage diagnose when > TRACE_MEMORY is on? I find __FILE__ and __LINE__ very helpful

Re: [HACKERS] shall we have a TRACE_MEMORY mode

2006-06-20 Thread Qingqing Zhou
"Alvaro Herrera" <[EMAIL PROTECTED]> wrote > > But the problem (or at last a part of the problem) is not what context > each chunk is allocated in, but where did a given chunk come from (where > was it allocated), Which is why saving __FILE__/__LINE__ is useful. > Agreed. Maybe we should not clut

Re: [HACKERS] shall we have a TRACE_MEMORY mode

2006-06-20 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Simon Riggs wrote: >> Could we set that as an option for each memory context when we create >> it? All or nothing seems too extreme for me for most cases. > What most cases? There is only one case -- there is a big leak and you > want to find out where

Re: [HACKERS] shall we have a TRACE_MEMORY mode

2006-06-20 Thread Greg Stark
Tom Lane <[EMAIL PROTECTED]> writes: > Another thing to consider is that the proximate location of the palloc > is frequently *not* very useful. For instance, if your memory is > getting eaten by lists, all the palloc traces will point at > new_tail_cell(). Not much help. I don't know what to d

Re: [HACKERS] shall we have a TRACE_MEMORY mode

2006-06-20 Thread Martijn van Oosterhout
On Tue, Jun 20, 2006 at 12:18:32AM -0400, Tom Lane wrote: > Another thing to consider is that the proximate location of the palloc > is frequently *not* very useful. For instance, if your memory is > getting eaten by lists, all the palloc traces will point at > new_tail_cell(). Not much help. I

Re: [HACKERS] shall we have a TRACE_MEMORY mode

2006-06-20 Thread Alvaro Herrera
Andrew Dunstan wrote: > Alvaro Herrera said: > > > > >> That seems mostly the hard way to me, because our memory management > >> scheme is *not* based around "thou shalt free() what thou malloc()ed". > >> You'd need a tool that understood about resetting memory contexts > >> (recursively) to get a

Re: [HACKERS] shall we have a TRACE_MEMORY mode

2006-06-20 Thread Andrew Dunstan
Alvaro Herrera said: > >> That seems mostly the hard way to me, because our memory management >> scheme is *not* based around "thou shalt free() what thou malloc()ed". >> You'd need a tool that understood about resetting memory contexts >> (recursively) to get anywhere at all in analyzing such a t

Re: [HACKERS] shall we have a TRACE_MEMORY mode

2006-06-20 Thread Alvaro Herrera
Simon Riggs wrote: > On Tue, 2006-06-20 at 00:18 -0400, Tom Lane wrote: > > > One idea that comes to mind is to have a compile time option to record > > the palloc __FILE__ and _LINE__ in every AllocChunk header. Then it > > would not be so hard to identify the culprit while trawling through > >

Re: [HACKERS] shall we have a TRACE_MEMORY mode

2006-06-20 Thread Simon Riggs
On Tue, 2006-06-20 at 00:18 -0400, Tom Lane wrote: > One idea that comes to mind is to have a compile time option to record > the palloc __FILE__ and _LINE__ in every AllocChunk header. Then it > would not be so hard to identify the culprit while trawling through > memory. The overhead costs wou

Re: [HACKERS] shall we have a TRACE_MEMORY mode

2006-06-20 Thread Gurjeet Singh
On 6/20/06, Tom Lane <[EMAIL PROTECTED]> wrote: One idea that comes to mind is to have a compile time option to record the palloc __FILE__ and _LINE__ in every AllocChunk header. Then it would not be so hard to identify the culprit while trawling through memory. The overhead costs would be so h

Re: [HACKERS] shall we have a TRACE_MEMORY mode

2006-06-19 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > About the exact form we'd give the feature: maybe write each > allocation/freeing to a per-backend file, say /tmp/pgmem.. Also > memory context creation, destruction, reset. Having the __FILE__ and > __LINE__ on each operation would be a good tracing t

Re: [HACKERS] shall we have a TRACE_MEMORY mode

2006-06-19 Thread Alvaro Herrera
Qingqing Zhou wrote: > As I follow Relyea Mike's recent post of possible memory leak, I think that > we are lack of a good way of identifing memory usage. Maybe we should also > remember __FILE__, __LINE__ etc for better memory usage diagnose when > TRACE_MEMORY is on? Hmm, this would have been a

[HACKERS] shall we have a TRACE_MEMORY mode

2006-06-19 Thread Qingqing Zhou
As I follow Relyea Mike's recent post of possible memory leak, I think that we are lack of a good way of identifing memory usage. Maybe we should also remember __FILE__, __LINE__ etc for better memory usage diagnose when TRACE_MEMORY is on? Regards, Qingqing ---(end of b