On 9/14/14 3:34 AM, Fabien COELHO wrote:
>> and rebased this patch on top of that.
>
> Applied and tested, everything looks fine.
>
> The only remaining question is whether the xmllint check should always
> be called. You stated that it was stricter than sgml processing, so I
> would think it wor
Hello Peter,
I've committed the $(missing) use separately,
That was simple and is a definite improvement.
Tiny detail: the new DBTOEPUB macro definition in "src/Makefile.global.in"
lacks another tab to be nicely aligned with the other definitions.
and rebased this patch on top of that.
On 8/21/14 4:28 PM, Fabien COELHO wrote:
> I'm fine with "$(missing)" or whatever else that provides a clear message.
I've committed the $(missing) use separately, and rebased this patch on
top of that.
>From cb2787b2473186239eb23e7320654513df8e8fb7 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
ISTM that it may be more helful to do:
ifndef JADE
#error "no jade found on your system, cannot generate the documention"
endif
We could use $(missing) for that, which is already used for bison, flex,
and perl.
I'm fine with "$(missing)" or whatever else that provides a clear message.
It is only run when the build is via XML/XSLT, not via SGML/DSSSL
(because the SGML/DSSSL build already checks the validity anyway).
I'm confused. I thought the point of this change was mostly that the
SGML toolchain is less strict than the XML toolchain, and you wanted
to have the more-stric
On 8/21/14 4:00 PM, Tom Lane wrote:
>> It is only run when the build is via XML/XSLT, not via SGML/DSSSL
>> (because the SGML/DSSSL build already checks the validity anyway).
>
> I'm confused. I thought the point of this change was mostly that the
> SGML toolchain is less strict than the XML tool
Peter Eisentraut writes:
> We could use $(missing) for that, which is already used for bison, flex,
> and perl.
+1 ... I'm surprised it's not like that already. Fabien's quite right to
complain that the Makefile has no business inserting defaults for things
configure couldn't find.
Peter Eisentraut writes:
> On 8/21/14 5:12 AM, Fabien COELHO wrote:
>> However, it seems that it is not run for target "html", nor for pdf/ps
>> targets. I'm wondering whether it is an oversight or if there is a
>> reason for that. Maybe the intention is that an explicit "htmlhelp" is
>> expected
On 8/21/14 5:12 AM, Fabien COELHO wrote:
> Also, a general comment, which is independent of this patch: I found the
> documentation build especially not resilient, with a lack of clear error
> messages when something is broken. Basically, if configure does not
> found something for the doc (openjad
On 8/21/14 5:12 AM, Fabien COELHO wrote:
>
> However, it seems that it is not run for target "html", nor for pdf/ps
> targets. I'm wondering whether it is an oversight or if there is a
> reason for that. Maybe the intention is that an explicit "htmlhelp" is
> expected to do the checking, but then
Also, a general comment, which is independent of this patch: I found the
documentation build especially not resilient, with a lack of clear error
messages when something is broken. Basically, if configure does not found
something for the doc (openjade, osx, xmllint, ...) it does not complain.
Hello Peter,
Agreed. I have committed the SGML changes that make things valid now,
but I will postpone the xmllint addition until the 9.5 branch, complete
with more documentation.
Per the above announcement, here is an updated patch, also with more
documentation and explanations.
It would e
12 matches
Mail list logo
