Re: [HACKERS] rm_desc signature

2014-06-16 Thread Heikki Linnakangas
On 06/17/2014 04:19 AM, Jeff Janes wrote: This commit, or a related one, changed the default (i.e. commented out) nature of: #define WAL_DEBUG Oops. Fixed, thanks! - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www

Re: [HACKERS] rm_desc signature

2014-06-16 Thread Jeff Janes
On Friday, June 13, 2014, Heikki Linnakangas wrote: > As part of the WAL-format changing patch I've been working on, I changed > the signature of the rm_desc function from: > > void (*rm_desc) (StringInfo buf, uint8 xl_info, char *rec); > void (*rm_desc) (StringInfo buf, XLogRecord *record); > >

Re: [HACKERS] rm_desc signature

2014-06-13 Thread Abhijit Menon-Sen
At 2014-06-13 13:39:58 +0200, and...@2ndquadrant.com wrote: > > > void (*rm_desc) (StringInfo buf, uint8 xl_info, char *rec); > > void (*rm_desc) (StringInfo buf, XLogRecord *record); > > > > […] > > +1. I've found this annoying in the past. I like it too. I was just moving some code from pg_xlo

Re: [HACKERS] rm_desc signature

2014-06-13 Thread Fujii Masao
On Fri, Jun 13, 2014 at 8:39 PM, Andres Freund wrote: > On 2014-06-13 14:37:33 +0300, Heikki Linnakangas wrote: >> As part of the WAL-format changing patch I've been working on, I changed the >> signature of the rm_desc function from: >> >> void (*rm_desc) (StringInfo buf, uint8 xl_info, char *rec

Re: [HACKERS] rm_desc signature

2014-06-13 Thread Andres Freund
On 2014-06-13 14:37:33 +0300, Heikki Linnakangas wrote: > As part of the WAL-format changing patch I've been working on, I changed the > signature of the rm_desc function from: > > void (*rm_desc) (StringInfo buf, uint8 xl_info, char *rec); > void (*rm_desc) (StringInfo buf, XLogRecord *record); >

[HACKERS] rm_desc signature

2014-06-13 Thread Heikki Linnakangas
As part of the WAL-format changing patch I've been working on, I changed the signature of the rm_desc function from: void (*rm_desc) (StringInfo buf, uint8 xl_info, char *rec); void (*rm_desc) (StringInfo buf, XLogRecord *record); The WAL-format patch needed that because it added more functions