Hello
I waited to fix.
Now I marked patch as ready for committer
Regards
Pavel
2013/12/1 Peter Geoghegan
> On Sat, Nov 30, 2013 at 11:30 PM, Pavel Stehule
> wrote:
> > After this fix it should be ready for commit
>
> Version with trivial, single token fix attached. I'm not sure if you
> ju
On Sat, Nov 30, 2013 at 11:30 PM, Pavel Stehule wrote:
> After this fix it should be ready for commit
Version with trivial, single token fix attached. I'm not sure if you
just forgot to mark this "ready for committer" in the commitfest app,
but if not you'll want to do so now.
I defer to the jud
On Sat, Nov 30, 2013 at 11:30 PM, Pavel Stehule wrote:
> After this fix it should be ready for commit
Whoops. I forgot to change that when I changed the name of the
parameter at the last minute. Sorry about that.
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgr
Hello
2013/12/1 Peter Geoghegan
> I've produced another revision, attached. Changes:
>
> * Fixes the compiler warnings on your environment.
>
> * Normalizes query string with the shared lock held (not always, just
> in case its needed). In master, this doesn't have to happen with a
> shared loc
I've produced another revision, attached. Changes:
* Fixes the compiler warnings on your environment.
* Normalizes query string with the shared lock held (not always, just
in case its needed). In master, this doesn't have to happen with a
shared lock held, so because of this, but also because of
2013/11/24 Peter Geoghegan
> On Sun, Nov 24, 2013 at 1:18 AM, Pavel Stehule
> wrote:
> > I got a compilation warning:
>
> I'll look into it.
>
> > * I tried do some basic benchmark, and I didn't see any negative on
> > performance related to implemented feature
>
> You're never going to see any
On Sun, Nov 24, 2013 at 1:18 AM, Pavel Stehule wrote:
> I got a compilation warning:
I'll look into it.
> * I tried do some basic benchmark, and I didn't see any negative on
> performance related to implemented feature
You're never going to see any performance impact with something like a
regul
Hello all
I did check of pg_stat_statements_ext_text.v2.2013_11_16.patch, that
introduce a external storage for query text
I got a compilation warning:
bash-4.1$ make all
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute
-W
"""
I am going to produce another revision in response to feedback already
received. I intend to outline the steps that it will take to resolve
some outstanding issues in the next day or so. It would be nice if you
could take a look at the revised patch that is ultimately produced.
Should I keep yo
On 21 January 2012 00:24, Kääriäinen Anssi wrote:
> I did not see any noticeable difference in runtimes with pg_stat_statements
> installed or uninstalled (as extension).
> Not tested on master without the patch at all.
>
> Overall the feature seems to be really useful.
Thanks for taking the tim
This is a short review of pg_stat_statements based on quick testing of the
feature.
1. Installation: after managing to actually build PostgreSQL and contrib
modules + changing
shared_preload_libraries to include pg_stat_statements I got this error:
FATAL: could not create shared memory segment:
11 matches
Mail list logo
