2013/9/12 Fabien COELHO
>
> Hello Pavel,
>
> Thanks for your review.
>
>
> * patched with minor warning
>> * compilable cleanly
>> * zero impact on PostgreSQL server functionality
>> * it does what was in proposal
>> ** change 5sec progress as default (instead no progress)
>> ** finalise a rate
2013/9/13 Fabien COELHO
>
> Hello,
>
> About patch eols:
>
>
>postgresql> patch -p1 < ../pgbench-measurements-v2.**patch
>>> patching file contrib/pgbench/pgbench.c
>>> patching file doc/src/sgml/pgbench.sgml
>>>
>>
>> it can depends on o.s. I did tests on Fedora 14. and for patching
Hello,
About patch eols:
postgresql> patch -p1 < ../pgbench-measurements-v2.patch
patching file contrib/pgbench/pgbench.c
patching file doc/src/sgml/pgbench.sgml
it can depends on o.s. I did tests on Fedora 14. and for patching without
warning I had to use dos2unix tool.
Hmmm. I
Dne 12. 9. 2013 17:34 "Fabien COELHO" napsal(a):
>
>
>> * patched with minor warning
>
>
>> some minor issue:
>>
>> patch warning
>>
>> make[1]: Leaving directory `/home/pavel/src/postgresql/config'
>> [pavel@localhost postgresql]$ patch -p1 < pgbench-measurements-v2.patch
>> (Stripping trailing C
* patched with minor warning
some minor issue:
patch warning
make[1]: Leaving directory `/home/pavel/src/postgresql/config'
[pavel@localhost postgresql]$ patch -p1 < pgbench-measurements-v2.patch
(Stripping trailing CRs from patch; use --binary to disable.)
patching file contrib/pgbench/pgb
Hello Pavel,
Thanks for your review.
* patched with minor warning
* compilable cleanly
* zero impact on PostgreSQL server functionality
* it does what was in proposal
** change 5sec progress as default (instead no progress)
** finalise a rate limit support - fixes a latency calculation
Just
Hello
* patched with minor warning
* compilable cleanly
* zero impact on PostgreSQL server functionality
* it does what was in proposal
** change 5sec progress as default (instead no progress)
** finalise a rate limit support - fixes a latency calculation
* code is clean
* documentation is includ