Re: [HACKERS] review: Deparsing DDL command strings

2012-12-04 Thread Pavel Stehule
2012/12/4 Dimitri Fontaine : > Pavel Stehule writes: >> I agree with these premisses. I am sure so normalised commands strings >> are very nice feature, that can be helpful for generation clean audit >> logs and messages. I see a one issue - testing a consistency between >> commands and their depa

Re: [HACKERS] review: Deparsing DDL command strings

2012-12-04 Thread Dimitri Fontaine
Pavel Stehule writes: > I agree with these premisses. I am sure so normalised commands strings > are very nice feature, that can be helpful for generation clean audit > logs and messages. I see a one issue - testing a consistency between > commands and their deparsed forms. Thanks. > Do you have

Re: [HACKERS] review: Deparsing DDL command strings

2012-12-04 Thread Pavel Stehule
Hello 2012/11/27 Dimitri Fontaine : > Hi, > > Pavel Stehule writes: >> ** missing doc > > I still would prefer to have an ack about the premises of this patch > before spending time on writing docs for it, namely: > > - we want a normalized command string (schema, auto naming of some >object

Re: [HACKERS] review: Deparsing DDL command strings

2012-11-27 Thread Dimitri Fontaine
Hi, Pavel Stehule writes: > ** missing doc I still would prefer to have an ack about the premises of this patch before spending time on writing docs for it, namely: - we want a normalized command string (schema, auto naming of some objects such as constraints and indexes, exporting default

Re: [HACKERS] review: Deparsing DDL command strings

2012-11-23 Thread Dimitri Fontaine
Pavel Stehule writes: > * some wrong in deparsing - doesn't support constraints > > postgres=# alter table a add column bbbsss int check (bbbsss > 0); > NOTICE: event: ddl_command_start, context: TOPLEVEL, tag: ALTER > TABLE, operation: ALTER, type: TABLE, schema: , name: > NOTICE: command: >

Re: [HACKERS] review: Deparsing DDL command strings

2012-11-23 Thread Pavel Stehule
Hello 2012/11/22 Dimitri Fontaine : > Hi, > > Thank you Pavel for reviewing my patch! :) > > Pavel Stehule writes: >> * issues >> >> ** missing doc > > Yes. I wanted to reach an agreement on why we need the de parsing for. > You can read the Last comment we made about it at the following link, I

Re: [HACKERS] review: Deparsing DDL command strings

2012-11-22 Thread Dimitri Fontaine
Hi, Thank you Pavel for reviewing my patch! :) Pavel Stehule writes: > * issues > > ** missing doc Yes. I wanted to reach an agreement on why we need the de parsing for. You can read the Last comment we made about it at the following link, I didn't have any answer to my proposal. http://arch

[HACKERS] review: Deparsing DDL command strings

2012-11-22 Thread Pavel Stehule
Hello Dimitri * patching (success) pavel ~/src/postgresql $ patch -p1 < binBUNnKQVPBP patching file src/backend/catalog/heap.c patching file src/backend/commands/event_trigger.c patching file src/backend/commands/extension.c patching file src/backend/commands/sequence.c patching file src/backend/