Re: [HACKERS] psql describe.c cleanup

2011-07-06 Thread Robert Haas
On Thu, Jun 16, 2011 at 10:05 AM, Merlin Moncure wrote: > On Wed, Jun 15, 2011 at 9:01 AM, Merlin Moncure wrote: >> On Tue, Jun 14, 2011 at 9:08 PM, Josh Kupershmidt wrote: >>> On Tue, Jun 14, 2011 at 12:15 PM, Merlin Moncure wrote: What I do wonder though is if the ; appending should real

Re: [HACKERS] psql describe.c cleanup

2011-06-16 Thread Merlin Moncure
On Wed, Jun 15, 2011 at 9:01 AM, Merlin Moncure wrote: > On Tue, Jun 14, 2011 at 9:08 PM, Josh Kupershmidt wrote: >> On Tue, Jun 14, 2011 at 12:15 PM, Merlin Moncure wrote: >>> What I do wonder though is if the ; appending should really be >>> happening in printQuery() instead of in each query -

Re: [HACKERS] psql describe.c cleanup

2011-06-15 Thread Merlin Moncure
On Tue, Jun 14, 2011 at 9:08 PM, Josh Kupershmidt wrote: > On Tue, Jun 14, 2011 at 12:15 PM, Merlin Moncure wrote: >> What I do wonder though is if the ; appending should really be >> happening in printQuery() instead of in each query -- the idea being >> that formatting for external consumption

Re: [HACKERS] psql describe.c cleanup

2011-06-14 Thread Josh Kupershmidt
On Tue, Jun 14, 2011 at 3:25 PM, Alvaro Herrera wrote: > pgindent moves strings back to the left when it thinks they fit within > 80 columns.  Yes, that seems pretty screwy. I am losing track of the ways in which pgindent has managed to mangle our source code :-/ Josh -- Sent via pgsql-hackers

Re: [HACKERS] psql describe.c cleanup

2011-06-14 Thread Josh Kupershmidt
On Tue, Jun 14, 2011 at 12:15 PM, Merlin Moncure wrote: > I did a quick review and test of your patch.  It didn't quite apply > cleanly due to recent non-related describe.c changes -- updated patch > attached. Thanks for looking at this. Your updated patch looks good to me. > First, I'll give yo

Re: [HACKERS] psql describe.c cleanup

2011-06-14 Thread Alvaro Herrera
Excerpts from Josh Kupershmidt's message of sáb may 07 16:40:35 -0300 2011: > And while I'm griping about describe.c, is it just me or is the source > code indentation in that file totally screwy? I'm using emacs and I've > loaded the snippet for pgsql-c-mode from > ./src/tools/editors/emacs.sampl

Re: [HACKERS] psql describe.c cleanup

2011-06-14 Thread Merlin Moncure
On Sat, May 7, 2011 at 2:40 PM, Josh Kupershmidt wrote: > Hi all, > > I use psql's -E mode every now and then, copy-and-pasting and further > tweaking the SQL displayed. Most queries are displayed terminated by a > semicolon, but quite a few aren't, making copy-and-paste just a bit > more tedious.

Re: [HACKERS] psql describe.c cleanup

2011-05-07 Thread Peter Eisentraut
On lör, 2011-05-07 at 15:40 -0400, Josh Kupershmidt wrote: > And while I'm griping about describe.c, is it just me or is the source > code indentation in that file totally screwy? I'm using emacs and I've > loaded the snippet for pgsql-c-mode from > ./src/tools/editors/emacs.samples into my ~/.emac