Re: [HACKERS] psql COPY vs. ON_ERROR_ROLLBACK, multi-command strings

2012-03-12 Thread Alvaro Herrera
Excerpts from Noah Misch's message of jue mar 08 12:11:37 -0300 2012: > > On Wed, Mar 07, 2012 at 04:57:12PM -0500, Robert Haas wrote: > > As a side note, the documentation for PQexec() is misleading about > > what will happen if COPY is present in a multi-command string. It > > says: "Note how

Re: [HACKERS] psql COPY vs. ON_ERROR_ROLLBACK, multi-command strings

2012-03-08 Thread Noah Misch
On Wed, Mar 07, 2012 at 04:57:12PM -0500, Robert Haas wrote: > On Sat, Feb 25, 2012 at 12:57 AM, Noah Misch wrote: > > Thanks. ?While testing a crashing function, I noticed that my above patch > > added some noise to psql output when the server crashes: > > > > [local] test=# select crashme(); > >

Re: [HACKERS] psql COPY vs. ON_ERROR_ROLLBACK, multi-command strings

2012-03-07 Thread Robert Haas
On Sat, Feb 25, 2012 at 12:57 AM, Noah Misch wrote: > Thanks.  While testing a crashing function, I noticed that my above patch > added some noise to psql output when the server crashes: > > [local] test=# select crashme(); > The connection to the server was lost. Attempting reset: Failed. > The c

Re: [HACKERS] psql COPY vs. ON_ERROR_ROLLBACK, multi-command strings

2012-02-24 Thread Noah Misch
On Wed, Jan 25, 2012 at 06:25:46PM -0300, Alvaro Herrera wrote: > Excerpts from Noah Misch's message of s??b ene 14 12:40:02 -0300 2012: > > It has bothered me that psql's \copy ignores the ON_ERROR_ROLLBACK setting. > > Only SendQuery() takes note of ON_ERROR_ROLLBACK, and \copy, like all > > back

Re: [HACKERS] psql COPY vs. ON_ERROR_ROLLBACK, multi-command strings

2012-01-25 Thread Alvaro Herrera
Excerpts from Noah Misch's message of sáb ene 14 12:40:02 -0300 2012: > It has bothered me that psql's \copy ignores the ON_ERROR_ROLLBACK setting. > Only SendQuery() takes note of ON_ERROR_ROLLBACK, and \copy, like all > backslash commands, does not route through SendQuery(). Looking into this >

[HACKERS] psql COPY vs. ON_ERROR_ROLLBACK, multi-command strings

2012-01-14 Thread Noah Misch
It has bothered me that psql's \copy ignores the ON_ERROR_ROLLBACK setting. Only SendQuery() takes note of ON_ERROR_ROLLBACK, and \copy, like all backslash commands, does not route through SendQuery(). Looking into this turned up several other weaknesses in psql's handling of COPY. For example, S