printQuery API change proposal (was Re: [HACKERS] psql \dFp's behavior)

2007-12-11 Thread Tom Lane
I wrote: > describe.c's whole approach to this has always been pretty thoroughly > broken in my mind, because it makes untenable assumptions about the > client-side gettext() producing strings that are in the current > client_encoding. If they are not, the server will probably reject > the SQL que

Re: [HACKERS] psql \dFp's behavior

2007-12-11 Thread Tom Lane
Guillaume Lelarge <[EMAIL PROTECTED]> writes: > Tom Lane a écrit : >> We should be fixing it so that the translated strings never go to the >> server and back at all. This doesn't seem amazingly hard for column >> headings --- it'd take some API additions in print.c, I think. > I'll take a look a

Re: [HACKERS] psql \dFp's behavior

2007-12-11 Thread Guillaume Lelarge
Tom Lane a écrit : > Guillaume Lelarge <[EMAIL PROTECTED]> writes: >> Tom Lane a écrit : >>> This seems mighty ugly, and it's not the way we handle any other \d >>> command. Why is it needed for \dFp (and only that)? > >> The problem here is that "Start parse" is translated with "Début de >> l'an

Re: [HACKERS] psql \dFp's behavior

2007-12-11 Thread Tom Lane
Guillaume Lelarge <[EMAIL PROTECTED]> writes: > Tom Lane a écrit : >> This seems mighty ugly, and it's not the way we handle any other \d >> command. Why is it needed for \dFp (and only that)? > The problem here is that "Start parse" is translated with "Début de > l'analyse" (which is a bad trans

Re: [HACKERS] psql \dFp's behavior

2007-12-11 Thread Guillaume Lelarge
Tom Lane a écrit : > Guillaume Lelarge <[EMAIL PROTECTED]> writes: >> I'm not sure psql handles \dFp the right way. The query allows >> translators to translate some columns' values but forgets to escape the >> strings. So, here is a patch that escapes these translated strings. > > This seems migh

Re: [HACKERS] psql \dFp's behavior

2007-12-11 Thread Tom Lane
Guillaume Lelarge <[EMAIL PROTECTED]> writes: > I'm not sure psql handles \dFp the right way. The query allows > translators to translate some columns' values but forgets to escape the > strings. So, here is a patch that escapes these translated strings. This seems mighty ugly, and it's not the wa

[HACKERS] psql \dFp's behavior

2007-12-11 Thread Guillaume Lelarge
Hi all, I'm not sure psql handles \dFp the right way. The query allows translators to translate some columns' values but forgets to escape the strings. So, here is a patch that escapes these translated strings. Regards. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com Index: src/b