Re: [HACKERS] psql: small patch to correct filename formatting error in '\s FILE' output

2013-11-05 Thread Tom Lane
Ian Lawrence Barwick writes: > 2013/9/10 Bruce Momjian : >> I still see that weird behavior in git head: >> >> pgdevel=# \s history.txt >> Wrote history to file "./history.txt". >> pgdevel=# \s /tmp/history.txt >> Wrote history to file ".//tmp/history.txt". >> pgdevel=# \cd /tmp >> pgdevel=# \s /

Re: [HACKERS] psql: small patch to correct filename formatting error in '\s FILE' output

2013-09-09 Thread Ian Lawrence Barwick
2013/9/10 Bruce Momjian : > On Tue, Jan 22, 2013 at 07:30:59PM -0500, Tom Lane wrote: >> Ian Lawrence Barwick writes: >> > Related email from the archives on this subject: >> > http://www.postgresql.org/message-id/37ed240d0611200645l5b70c8ddw5fb735e0d35a7...@mail.gmail.com >> >> I agree with the o

Re: [HACKERS] psql: small patch to correct filename formatting error in '\s FILE' output

2013-09-09 Thread Bruce Momjian
On Tue, Jan 22, 2013 at 07:30:59PM -0500, Tom Lane wrote: > Ian Lawrence Barwick writes: > > Related email from the archives on this subject: > > http://www.postgresql.org/message-id/37ed240d0611200645l5b70c8ddw5fb735e0d35a7...@mail.gmail.com > > I agree with the opinion stated there that \cd wit

Re: [HACKERS] psql: small patch to correct filename formatting error in '\s FILE' output

2013-01-22 Thread Tom Lane
Ian Lawrence Barwick writes: > Related email from the archives on this subject: > http://www.postgresql.org/message-id/37ed240d0611200645l5b70c8ddw5fb735e0d35a7...@mail.gmail.com I agree with the opinion stated there that \cd with no argument really ought to do what "cd" with no argument usually

Re: [HACKERS] psql: small patch to correct filename formatting error in '\s FILE' output

2013-01-22 Thread Ian Lawrence Barwick
2013/1/23 Tom Lane : > I wrote: >> If we did think that this specific backslash command needed to be able >> to print something other than the filename as-entered, I'd be inclined >> to just apply make_absolute_path() to the name, instead of relying on >> inadequate dead-reckoning. However, that w

Re: [HACKERS] psql: small patch to correct filename formatting error in '\s FILE' output

2013-01-22 Thread Tom Lane
I wrote: > If we did think that this specific backslash command needed to be able > to print something other than the filename as-entered, I'd be inclined > to just apply make_absolute_path() to the name, instead of relying on > inadequate dead-reckoning. However, that would require making > make_

Re: [HACKERS] psql: small patch to correct filename formatting error in '\s FILE' output

2013-01-22 Thread Dickson S. Guedes
2013/1/22 Tom Lane : > Why should \s, and \s alone, > need to remind you where you're cd'd to? Why not just get rid of that prefixed cd'd path in \s? []s -- Dickson S. Guedes mail/xmpp: gue...@guedesoft.net - skype: guediz http://github.com/guedes - http://guedesoft.net http://www.postgresql.org

Re: [HACKERS] psql: small patch to correct filename formatting error in '\s FILE' output

2013-01-22 Thread Tom Lane
Ian Lawrence Barwick writes: > I've noticed a filename error in feedback messages from psql's '\s' command > when saving the command line history to a file specified by an absolute > filepath: > psql (9.2.2) > Type "help" for help. > pgdevel=# \s history.txt > Wrote history to file "./hi

[HACKERS] psql: small patch to correct filename formatting error in '\s FILE' output

2013-01-20 Thread Ian Lawrence Barwick
I've noticed a filename error in feedback messages from psql's '\s' command when saving the command line history to a file specified by an absolute filepath: psql (9.2.2) Type "help" for help. pgdevel=# \s history.txt Wrote history to file "./history.txt". pgdevel=# \s /tmp/history.txt