Re: [HACKERS] psql: display of object comments

2011-08-11 Thread Robert Haas
On Mon, Aug 8, 2011 at 6:01 PM, Josh Kupershmidt wrote: > On Mon, Aug 8, 2011 at 4:34 PM, Robert Haas wrote: >> OK, I've now committed most of this, with some additions to the >> documentation.  Remaining bits attached. > > Looks good, thanks. And now I've committed (nearly) all of what remains.

Re: [HACKERS] psql: display of object comments

2011-08-11 Thread Robert Haas
2011/8/9 Shigeru Hanada : > I'm the author of that patch, sorry for confusion.  May I explain the > background of implementing those command? :) > > Basically, during implementing foreign table support, I tried to follow > the existing design. > > I found two backslash command groups in psql, \de[w

Re: [HACKERS] psql: display of object comments

2011-08-08 Thread Shigeru Hanada
(2011/08/09 7:01), Josh Kupershmidt wrote: >> I am a bit confused as to why we have both \det and \dE. They seem >> redundant. Shouldn't we rip one of those out? IMHO, \det should be >> the one to go, as it could be useful to do, e.g. \dtvE, which isn't >> going to work with the \det syntax. >

Re: [HACKERS] psql: display of object comments

2011-08-08 Thread Josh Kupershmidt
On Mon, Aug 8, 2011 at 6:01 PM, Josh Kupershmidt wrote: > (i.e. add "Options" column to \dE+ if we keep that one). Oh nevermind, "Options" is displayed by \d+ foreign_table_name. Josh -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: ht

Re: [HACKERS] psql: display of object comments

2011-08-08 Thread Josh Kupershmidt
On Mon, Aug 8, 2011 at 4:34 PM, Robert Haas wrote: > OK, I've now committed most of this, with some additions to the > documentation.  Remaining bits attached. Looks good, thanks. > I am a bit confused as to why we have both \det and \dE.  They seem > redundant.  Shouldn't we rip one of those ou

Re: [HACKERS] psql: display of object comments

2011-08-08 Thread Robert Haas
On Fri, Aug 5, 2011 at 7:25 PM, Josh Kupershmidt wrote: > On Fri, Aug 5, 2011 at 8:32 AM, Robert Haas wrote: >> I guess my vote is to make the SQL/MED stuff show the description only >> in verbose mode, and always at the end; and revise what we did with >> \dL to put the description at the end ev

Re: [HACKERS] psql: display of object comments

2011-08-05 Thread Robert Haas
On Thu, Aug 4, 2011 at 10:24 PM, Josh Kupershmidt wrote: > A few existing backslash commands, such as \dn and maybe \db, don't > exactly follow this precedent. Not sure if we want to bother adjusting > the existing commands to be consistent in this regard. Defining > "typical usage" is pretty wish

Re: [HACKERS] psql: display of object comments

2011-08-04 Thread Josh Kupershmidt
On Thu, Aug 4, 2011 at 12:26 PM, Robert Haas wrote: > On Tue, Jul 26, 2011 at 8:38 PM, Josh Kupershmidt wrote: >> [new patch] > > I've committed the portion of this that displays comments on languages > and casts. Thanks! > For domains and conversions, I am wondering if we should display the >

Re: [HACKERS] psql: display of object comments

2011-07-25 Thread Robert Haas
On Fri, Jul 22, 2011 at 10:44 PM, Josh Kupershmidt wrote: > On Sat, Jul 9, 2011 at 1:16 PM, Josh Kupershmidt wrote: > > Attached is an updated version of this patch, lifted out of the recent > pg_comments patch. With this v2 patch, \dd should properly show just > its five object types, and the ps