On Wed, Jan 19, 2011 at 11:19 PM, Josh Kupershmidt wrote:
> On Wed, Jan 19, 2011 at 9:09 PM, Robert Haas wrote:
>> This patch doesn't seem terribly consistent to me - we show the name
>> of the call handler and the name of the validator, but for the inline
>> handler we just indicate whether ther
On Wed, Jan 19, 2011 at 9:09 PM, Robert Haas wrote:
> This patch doesn't seem terribly consistent to me - we show the name
> of the call handler and the name of the validator, but for the inline
> handler we just indicate whether there is one or not. That seems like
> something that we should mak
On Wed, Jan 19, 2011 at 5:47 PM, Andreas Karlsson wrote:
> The patch looks alright now so I will mark it as ready for committer
> now.
This patch doesn't seem terribly consistent to me - we show the name
of the call handler and the name of the validator, but for the inline
handler we just indicat
On Tue, 2011-01-18 at 19:34 -0500, Josh Kupershmidt wrote:
> Got that now too. I lost my ~/.emacs file recently, which is mostly
> why I'm making whitespace mistakes. Rebuilding slowly though;
> (setq-default show-trailing-whitespace t) is what I needed.
Aha, I see.
> I left the "Call Handler" an
On Tue, Jan 18, 2011 at 1:35 PM, Andreas Karlsson wrote:
> Hi Josh,
>
> Nope, I do not have any better ideas than "DO Blocks?".
>
> Everything looks good with the exception one bug now.
>
> \dL foo
> * QUERY **
> SELECT l.lanname AS "Name",
> pg_catalog.pg_get_userbyid(l.lano
Hi Josh,
Nope, I do not have any better ideas than "DO Blocks?".
Everything looks good with the exception one bug now.
\dL foo
* QUERY **
SELECT l.lanname AS "Name",
pg_catalog.pg_get_userbyid(l.lanowner) as "Owner",
l.lanpltrusted AS "Trusted"
FROM pg_catalog.pg_la
Hi all,
I've updated the patch to address the following points:
* help string now says "list procedural languages" (no parentheses now)
* the language name column is now titled "Name"
* added another column in verbose mode for 9.0+ showing whether DO
blocks are possible with the language. I nam
On Sun, 2011-01-16 at 22:32 -0500, Josh Kupershmidt wrote:
> On Sat, Jan 15, 2011 at 8:26 PM, Andreas Karlsson wrote:
> > Should we include a column in \dL+ for the laninline function (DO
> > blocks)?
>
> Hrm, I guess that could be useful for the verbose output at least.
Magnus Hagander agreed w
On Mon, 2011-01-17 at 07:37 +0100, Magnus Hagander wrote:
> Yeah. Procedural langauges may strictly be wrong, but people aren't
> likely to misunderstand it.
That was idea when suggesting we call it "procedural languages". It is
short and I do not think it can be misunderstood.
Regards,
Andreas
Peter Eisentraut wrote:
> On m?n, 2011-01-17 at 07:37 +0100, Magnus Hagander wrote:
> > >> which, as Magnus points out, includes non-procedural languages (SQL).
> > >>
> > >> I think that "list languages" could be confusing to newcomers -- the
> > >> very people who might be reading through the hel
On Mon, Jan 17, 2011 at 02:48:43PM +0200, Peter Eisentraut wrote:
> On mån, 2011-01-17 at 07:37 +0100, Magnus Hagander wrote:
> > >> which, as Magnus points out, includes non-procedural languages
> > >> (SQL).
> > >>
> > >> I think that "list languages" could be confusing to newcomers
> > >> -- the
On mån, 2011-01-17 at 07:37 +0100, Magnus Hagander wrote:
> >> which, as Magnus points out, includes non-procedural languages (SQL).
> >>
> >> I think that "list languages" could be confusing to newcomers -- the
> >> very people who might be reading through the help output of psql for
> >> the firs
On Mon, Jan 17, 2011 at 05:22, Robert Haas wrote:
> On Sun, Jan 16, 2011 at 10:40 PM, Josh Kupershmidt wrote:
>> On Sun, Jan 16, 2011 at 8:52 PM, Robert Haas wrote:
>>> On Sun, Jan 16, 2011 at 7:04 AM, Magnus Hagander
>>> wrote:
> I do not like the use of parentheses in the usage descripti
On Sun, Jan 16, 2011 at 10:40 PM, Josh Kupershmidt wrote:
> On Sun, Jan 16, 2011 at 8:52 PM, Robert Haas wrote:
>> On Sun, Jan 16, 2011 at 7:04 AM, Magnus Hagander wrote:
I do not like the use of parentheses in the usage description "list
(procedural) languages". Why not have it simply
On Sun, Jan 16, 2011 at 8:52 PM, Robert Haas wrote:
> On Sun, Jan 16, 2011 at 7:04 AM, Magnus Hagander wrote:
>>> I do not like the use of parentheses in the usage description "list
>>> (procedural) languages". Why not have it simply as "list procedural
>>> languages"?
>>
>> Because it lists non-
On Sat, Jan 15, 2011 at 8:26 PM, Andreas Karlsson wrote:
> Hi Josh,
>
> Here is my review of this patch for the commitfest.
>
> Review of https://commitfest.postgresql.org/action/patch_view?id=439
Thanks a lot for the review!
> Contents and Purpose
>
>
> This patch adds the
On Sun, Jan 16, 2011 at 7:04 AM, Magnus Hagander wrote:
>> I do not like the use of parentheses in the usage description "list
>> (procedural) languages". Why not have it simply as "list procedural
>> languages"?
>
> Because it lists non-procedural langauges as well? (I didn't check it,
> that's j
On Sun, Jan 16, 2011 at 02:26, Andreas Karlsson wrote:
> Hi Josh,
>
> Contents and Purpose
>
>
> This patch adds the \dL command in psql to list the procedual languages.
> Some things I noticed when using it though.
>
> I do not like the use of parentheses in the usage des
Hi Josh,
Here is my review of this patch for the commitfest.
Review of https://commitfest.postgresql.org/action/patch_view?id=439
Contents and Purpose
This patch adds the \dL command in psql to list the procedual languages.
To me this seems like a useful addition to the co
On Sun, Nov 21, 2010 at 9:44 PM, Josh Kupershmidt wrote:
> On Sun, Nov 21, 2010 at 8:39 PM, Robert Haas wrote:
>> Please add this patch to the currently open CommitFest:
>
> Added to 2011-01.
>
>> https://commitfest.postgresql.org/action/commitfest_view/open
>>
>> And please also help with review
On Sun, Nov 21, 2010 at 8:39 PM, Robert Haas wrote:
> Please add this patch to the currently open CommitFest:
Added to 2011-01.
> https://commitfest.postgresql.org/action/commitfest_view/open
>
> And please also help with review of patches from the current CommitFest:
>
> https://commitfest.post
On Sun, Nov 21, 2010 at 8:18 PM, Josh Kupershmidt wrote:
> I'd like to revive Fernando Ike's patch implementing the "\dL" command
> for psql to list available languages, last version here:
> http://archives.postgresql.org/pgsql-hackers/2009-07/msg01092.php
Please add this patch to the currently
Hi all,
I'd like to revive Fernando Ike's patch implementing the "\dL" command
for psql to list available languages, last version here:
http://archives.postgresql.org/pgsql-hackers/2009-07/msg01092.php
The original patch produced columns "Name", "Owner", "Procedural
Language", "Trusted", "Call
23 matches
Mail list logo
