2014-09-10 0:13 GMT+02:00 Andres Freund :
> On 2014-09-09 22:22:45 +0200, Andres Freund wrote:
> > I plan to push this soon.
>
> Done.
>
> Thanks for the patch!
>
Thank you very much
Pavel
>
> Andres Freund
>
> --
> Andres Freund http://www.2ndQuadrant.com/
> PostgreSQL D
On 2014-09-09 22:22:45 +0200, Andres Freund wrote:
> I plan to push this soon.
Done.
Thanks for the patch!
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql
Hi,
Given we already have three topics for --help and I can see others I
went with my --help= proposal.
On 2014-08-28 13:20:07 +0200, Andres Freund wrote:
> Some stuff I changed:
> * I rephrased the sgml changes
> * s/Printing options/Display options/. Or maybe "Display influencing
> variables"
On 2014-08-28 13:54:28 +0200, Andres Freund wrote:
> On 2014-08-28 13:20:07 +0200, Andres Freund wrote:
> > I've attached a incremental patch.
>
> Apparently I didn't attach the patch, as so much a file containing the
> name of the patchfile...
Which you obviously didn't integrate. And didn't com
Hi
here is a second variant with support --help=variables
Regards
Pavel
2014-09-04 4:25 GMT+02:00 Robert Haas :
> On Thu, Aug 28, 2014 at 11:20 AM, Andres Freund
> wrote:
> >> >* How about making it --help=variables instead of --help-variables?
> >>
> >> -1, help is not a variable to be assi
On Thu, Aug 28, 2014 at 11:20 AM, Andres Freund wrote:
>> >* How about making it --help=variables instead of --help-variables?
>>
>> -1, help is not a variable to be assigned imho
>
> I don't think variable assignment is a good mental model for long
> commandline arguments. And it's not like I'm t
Hello
fixed ECHO, ECHO_HIDDEN, PROPMPT
Regards
Pavel
2014-09-01 11:52 GMT+02:00 Fujii Masao :
> On Thu, Aug 28, 2014 at 9:34 PM, Pavel Stehule
> wrote:
> >
> >
> >
> > 2014-08-28 14:22 GMT+02:00 Fujii Masao :
> >
> >> On Thu, Aug 28, 2014 at 5:48 AM, Pavel Stehule >
> >> wrote:
> >> > comm
On Thu, Aug 28, 2014 at 9:34 PM, Pavel Stehule wrote:
>
>
>
> 2014-08-28 14:22 GMT+02:00 Fujii Masao :
>
>> On Thu, Aug 28, 2014 at 5:48 AM, Pavel Stehule
>> wrote:
>> > comments?
>>
>> +fprintf(output, _(" ECHO control what input is
>> written to standard output [all, queries]
On 2014-08-28 14:04:27 +0200, Petr Jelinek wrote:
> On 28/08/14 13:20, Andres Freund wrote:
> >Hi,
> >
> >Stuff I wondered about:
> >* How about making it --help=variables instead of --help-variables?
>
> -1, help is not a variable to be assigned imho
I don't think variable assignment is a good m
2014-08-28 14:22 GMT+02:00 Fujii Masao :
> On Thu, Aug 28, 2014 at 5:48 AM, Pavel Stehule
> wrote:
> > comments?
>
> +fprintf(output, _(" ECHO control what input is
> written to standard output [all, queries]\n"));
>
> The valid values in the help messages should be consistent
On Thu, Aug 28, 2014 at 5:48 AM, Pavel Stehule wrote:
> comments?
+fprintf(output, _(" ECHO control what input is
written to standard output [all, queries]\n"));
The valid values in the help messages should be consistent with
the values that the tab-completion displays. So in
On 28/08/14 13:20, Andres Freund wrote:
Hi,
Stuff I wondered about:
* How about making it --help=variables instead of --help-variables?
-1, help is not a variable to be assigned imho
* Do we really need the 'Report bugs to' blurb for --help-variables?
Probably not.
* Since we're not exha
2014-08-28 13:20 GMT+02:00 Andres Freund :
> Hi,
>
> On 2014-08-27 22:48:54 +0200, Pavel Stehule wrote:
> > Hi
> >
> > I chose \? xxx, because it is related to psql features. I wrote commands:
> >
> > \? options
> > \? variables
> >
> > comments?
>
> Generall I like it.
>
> Some stuff I changed:
>
On 2014-08-28 13:20:07 +0200, Andres Freund wrote:
> I've attached a incremental patch.
Apparently I didn't attach the patch, as so much a file containing the
name of the patchfile...
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Develo
On Thu, Aug 28, 2014 at 8:20 PM, Andres Freund wrote:
> Hi,
>
> On 2014-08-27 22:48:54 +0200, Pavel Stehule wrote:
>> Hi
>>
>> I chose \? xxx, because it is related to psql features. I wrote commands:
>>
>> \? options
>> \? variables
>>
>> comments?
>
> Generall I like it.
>
> Some stuff I changed
Hi,
On 2014-08-27 22:48:54 +0200, Pavel Stehule wrote:
> Hi
>
> I chose \? xxx, because it is related to psql features. I wrote commands:
>
> \? options
> \? variables
>
> comments?
Generall I like it.
Some stuff I changed:
* I rephrased the sgml changes
* s/Printing options/Display options/.
Hi
I chose \? xxx, because it is related to psql features. I wrote commands:
\? options
\? variables
comments?
Regards
Pavel
2014-08-26 13:48 GMT+02:00 Andres Freund :
> On 2014-08-26 13:44:16 +0200, Pavel Stehule wrote:
> > 2014-08-26 13:30 GMT+02:00 Petr Jelinek :
> >
> > > On 26/08/14 1
On 2014-08-26 13:44:16 +0200, Pavel Stehule wrote:
> 2014-08-26 13:30 GMT+02:00 Petr Jelinek :
>
> > On 26/08/14 13:20, Andres Freund wrote:
> >
> >>
> >> I'm looking at committing this, but I wonder: Shouldn't this be
> >> accessible from inside psql as well? I.e. as a backslash command?
> >>
> >
2014-08-26 13:30 GMT+02:00 Petr Jelinek :
> On 26/08/14 13:20, Andres Freund wrote:
>
>>
>> I'm looking at committing this, but I wonder: Shouldn't this be
>> accessible from inside psql as well? I.e. as a backslash command?
>>
>>
> +1
>
have you idea about command name? \?+
Pavel
>
>
> --
On 26/08/14 13:20, Andres Freund wrote:
I'm looking at committing this, but I wonder: Shouldn't this be
accessible from inside psql as well? I.e. as a backslash command?
+1
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Servic
On 2014-06-29 18:54:50 +0530, Abhijit Menon-Sen wrote:
> At 2014-06-29 20:35:04 +0900, maumau...@gmail.com wrote:
> >
> > Thanks, I marked it as ready for committer. I hope Fujii san or
> > another committer will commit this, refining English expression if
> > necessary.
>
> Since it was just a m
Abhijit Menon-Sen wrote:
> At 2014-06-29 20:35:04 +0900, maumau...@gmail.com wrote:
> >
> > Thanks, I marked it as ready for committer. I hope Fujii san or
> > another committer will commit this, refining English expression if
> > necessary.
>
> Since it was just a matter of editing, I went throu
2014-06-29 15:24 GMT+02:00 Abhijit Menon-Sen :
> At 2014-06-29 20:35:04 +0900, maumau...@gmail.com wrote:
> >
> > Thanks, I marked it as ready for committer. I hope Fujii san or
> > another committer will commit this, refining English expression if
> > necessary.
>
> Since it was just a matter of
At 2014-06-29 20:35:04 +0900, maumau...@gmail.com wrote:
>
> Thanks, I marked it as ready for committer. I hope Fujii san or
> another committer will commit this, refining English expression if
> necessary.
Since it was just a matter of editing, I went through the patch and
corrected various mino
2014-06-29 13:35 GMT+02:00 MauMau :
> Thanks, I marked it as ready for committer. I hope Fujii san or another
> committer will commit this, refining English expression if necessary.
>
sure
Thank you very much
Regards
Pavel
>
> Regards
> MauMau
>
>
Thanks, I marked it as ready for committer. I hope Fujii san or another
committer will commit this, refining English expression if necessary.
Regards
MauMau
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/m
Hi
2014-06-29 0:48 GMT+02:00 MauMau :
> From: "Pavel Stehule"
>
> I modified description of setting system variables in dependency on O.S.
>>
>
> Thank you, it's almost OK. As mentioned in my previous mail, I think
> "determines" should be "determine" to follow other messages. I'll mark
> th
From: "Pavel Stehule"
I modified description of setting system variables in dependency on O.S.
Thank you, it's almost OK. As mentioned in my previous mail, I think
"determines" should be "determine" to follow other messages. I'll mark this
patch as ready for committer when this is fixed.
Hello
I modified description of setting system variables in dependency on O.S.
Regards
Pavel
2014-06-27 8:54 GMT+02:00 Pavel Stehule :
> Hello
>
> thank you Peter, so now only setting for MS Windows is missing?
>
> Regards
>
> Pavel
>
>
> 2014-06-26 21:57 GMT+02:00 Petr Jelinek :
>
> Hello,
Hello
thank you Peter, so now only setting for MS Windows is missing?
Regards
Pavel
2014-06-26 21:57 GMT+02:00 Petr Jelinek :
> Hello,
>
> I went through the patch, seems mostly fine, I adjusted some wording,
> removed the default .pgpass file info since it's not accurate, and replaced
> coup
Hello,
I went through the patch, seems mostly fine, I adjusted some wording,
removed the default .pgpass file info since it's not accurate, and
replaced couple of phrases with (hopefully) more informative ones.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Develop
2014-06-26 15:26 GMT+02:00 MauMau :
> Hello,
>
> From: "Pavel Stehule"
>
>> fixed
>>
>
> Thank you. All is fine.
>
>
>
> should be ""Environment variables". And this section lacks description
>>> for Windows, such as:
>>>
>>> + printf(_(" NAME=VALUE [NAME=VALUE] psql ...\n or \\setenv NAME
>
Hello,
From: "Pavel Stehule"
fixed
Thank you. All is fine.
should be ""Environment variables". And this section lacks description
for Windows, such as:
+ printf(_(" NAME=VALUE [NAME=VALUE] psql ...\n or \\setenv NAME
[VALUE]
in interactive mode\n\n"));
+ printf(_(" PGPASSFILE
Hello
Here is next update
2014-06-25 17:17 GMT+02:00 MauMau :
> OK, let me help you, though I'm only a Japanese who is never confident in
> my English.
>
> (1)
> As Fujii-san pointed out, could you add explanation for --help-variables
> in doc/src/sgml/ref/psqlref.sgml?
>
>
> (2)
>
> + printf(_
OK, let me help you, though I'm only a Japanese who is never confident in my
English.
(1)
As Fujii-san pointed out, could you add explanation for --help-variables in
doc/src/sgml/ref/psqlref.sgml?
(2)
+ printf(_(" --help-variables list of available configuration
variables (options)
Hello
I am sending little bit modified patch by Fujii' comments - but I am not
able to fix it more - it is task for someone with better English skill then
I have
Regards
Pavel
2014-06-23 10:02 GMT+02:00 Fujii Masao :
> On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule
> wrote:
> > Hello
> >
>
2014-06-23 11:53 GMT+02:00 Fujii Masao :
> On Mon, Jun 23, 2014 at 6:06 PM, Pavel Stehule
> wrote:
> >
> >
> >
> > 2014-06-23 10:57 GMT+02:00 Fujii Masao :
> >
> >> On Mon, Jun 23, 2014 at 5:10 PM, Pavel Stehule >
> >> wrote:
> >> > Hello
> >> >
> >> >
> >> > 2014-06-23 10:02 GMT+02:00 Fujii Mas
On Mon, Jun 23, 2014 at 6:06 PM, Pavel Stehule wrote:
>
>
>
> 2014-06-23 10:57 GMT+02:00 Fujii Masao :
>
>> On Mon, Jun 23, 2014 at 5:10 PM, Pavel Stehule
>> wrote:
>> > Hello
>> >
>> >
>> > 2014-06-23 10:02 GMT+02:00 Fujii Masao :
>> >
>> >> On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule
>> >>
2014-06-23 10:57 GMT+02:00 Fujii Masao :
> On Mon, Jun 23, 2014 at 5:10 PM, Pavel Stehule
> wrote:
> > Hello
> >
> >
> > 2014-06-23 10:02 GMT+02:00 Fujii Masao :
> >
> >> On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule <
> pavel.steh...@gmail.com>
> >> wrote:
> >> > Hello
> >> >
> >> > third vers
On Mon, Jun 23, 2014 at 5:10 PM, Pavel Stehule wrote:
> Hello
>
>
> 2014-06-23 10:02 GMT+02:00 Fujii Masao :
>
>> On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule
>> wrote:
>> > Hello
>> >
>> > third version with Erik's update
>>
>> Here are some my comments:
>>
>> The document of psql needs to be
Hello
2014-06-23 10:02 GMT+02:00 Fujii Masao :
> On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule
> wrote:
> > Hello
> >
> > third version with Erik's update
>
> Here are some my comments:
>
> The document of psql needs to be updated. At least the description of new
> option
> this patch adds ne
On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule wrote:
> Hello
>
> third version with Erik's update
Here are some my comments:
The document of psql needs to be updated. At least the description of new option
this patch adds needs to be added into the document.
+printf(_(" --help-variables
PMPT3
>
> SIGLELINE
>
> I fixed those in my patch and improved the text.
> Attached is the diff against your v1 patch
>
>
> Thanks,
>
>
> Erik
>
>
>
>
>
>
>
>
> ---- Original Message
> ----
2014-06-22 9:32 GMT+02:00 MauMau :
> From: "Pavel Stehule"
>
> pg_dumpall aligns all options left with each other, whether they are short
>>> or long.
>>>
>>> -x, --no-privileges do not dump privileges (grant/revoke)
>>> --binary-upgrade for use by upgrade utilities only
>
From: "Pavel Stehule"
pg_dumpall aligns all options left with each other, whether they are
short
or long.
-x, --no-privileges do not dump privileges (grant/revoke)
--binary-upgrade for use by upgrade utilities only
--column-inserts dump data as INSERT comman
2014-06-22 2:26 GMT+02:00 MauMau :
> From: "Pavel Stehule"
>
> I am not sure in this point. It is aligned left with all long options:
>>
>> -?, --help show this help, then exit
>> --help-variables list of available configuration variables
>> (options), then exit
>>
>
> pg
From: "Pavel Stehule"
I am not sure in this point. It is aligned left with all long options:
-?, --help show this help, then exit
--help-variables list of available configuration variables
(options), then exit
pg_dumpall aligns all options left with each other, whether
On Sun, June 22, 2014 00:10, Pavel Stehule wrote:
> [help-variables-01.patch ]
+1. This patch is a very useful improvement, IMHO.
I edited the text somewhat; and removed some obvious typos.
thanks,
Erik Rijkers--- src/bin/psql/help.c.orig 2014-06-22 00:31:55.450860460 +0200
+++ src/bin/psql/h
Hello
2014-06-21 15:51 GMT+02:00 MauMau :
> eFrom: "Pavel Stehule"
>
>> here is a prototype:
>>
>
> The patch applied and built with success. There are a few minor things:
>
>
> (1)
> help_variables() lacks description of some variables such as SINGLELINE
> and SINGLESTEP. I think this help s
eFrom: "Pavel Stehule"
here is a prototype:
The patch applied and built with success. There are a few minor things:
(1)
help_variables() lacks description of some variables such as SINGLELINE and
SINGLESTEP. I think this help should list all available variables, because
users may want to
2014-03-01 23:53 GMT+01:00 Fabrízio de Royes Mello
:
>
> On Sat, Mar 1, 2014 at 5:37 AM, Pavel Stehule
> wrote:
> >
> > Hello
> >
> > here is a prototype:
> >
> > bash-4.1$ /usr/local/pgsql/bin/psql --help-variables
> > List of some variables (options) for use from command line.
> > Complete lis
On Sat, Mar 1, 2014 at 5:37 AM, Pavel Stehule
wrote:
>
> Hello
>
> here is a prototype:
>
> bash-4.1$ /usr/local/pgsql/bin/psql --help-variables
> List of some variables (options) for use from command line.
> Complete list you find in psql section in the PostgreSQL documentation.
>
> psql variable
Hello
here is a prototype:
bash-4.1$ /usr/local/pgsql/bin/psql --help-variables
List of some variables (options) for use from command line.
Complete list you find in psql section in the PostgreSQL documentation.
psql variables:
Usage:
psql --set=NAME=VALUE
or \set NAME VALUE in interactive m
2014-02-28 22:52 GMT+01:00 Erik Rijkers :
> e.g.: -v ON_ERROR_STOP=1
I checked it and it is not the most long line there, so it can be a good
solution.
Pavel
2014-02-28 23:01 GMT+01:00 Andrew Dunstan :
>
> On 02/28/2014 04:38 PM, Tom Lane wrote:
>
>> Andrew Dunstan writes:
>>
>>> Well, then we just have to add more info to --help
>>> +1 for at least doing that. I found it annoying just the other day not
>>> to find it in plsql's --help output, in
On 02/28/2014 04:38 PM, Tom Lane wrote:
Andrew Dunstan writes:
Well, then we just have to add more info to --help
+1 for at least doing that. I found it annoying just the other day not
to find it in plsql's --help output, in a moment of brain fade when I
forgot how to spell it. So it's not ju
2014-02-28 22:52 GMT+01:00 Erik Rijkers :
> On Fri, February 28, 2014 22:38, Tom Lane wrote:
> > Andrew Dunstan writes:
> >>> Well, then we just have to add more info to --help
> >
> >> +1 for at least doing that. I found it annoying just the other day not
> >> to find it in plsql's --help output
On Fri, February 28, 2014 22:38, Tom Lane wrote:
> Andrew Dunstan writes:
>>> Well, then we just have to add more info to --help
>
>> +1 for at least doing that. I found it annoying just the other day not
>> to find it in plsql's --help output, in a moment of brain fade when I
>> forgot how to spe
2014-02-28 22:38 GMT+01:00 Tom Lane :
> Andrew Dunstan writes:
> >> Well, then we just have to add more info to --help
>
> > +1 for at least doing that. I found it annoying just the other day not
> > to find it in plsql's --help output, in a moment of brain fade when I
> > forgot how to spell it.
Andrew Dunstan writes:
>> Well, then we just have to add more info to --help
> +1 for at least doing that. I found it annoying just the other day not
> to find it in plsql's --help output, in a moment of brain fade when I
> forgot how to spell it. So it's not just beginners who can benefit, it'
On 02/28/2014 01:27 PM, Pavel Stehule wrote:
>
> three chars is not important
>
> important is a placing in --help output
>
Well, then we just have to add more info to --help
it can be solution
+1 for at least doing that. I found it annoying just the other day
2014-02-28 19:55 GMT+01:00 Fabrízio de Royes Mello
:
>
> On Fri, Feb 28, 2014 at 3:44 PM, Alvaro Herrera
> wrote:
> >
> > Fabrízio de Royes Mello escribió:
> > > On Fri, Feb 28, 2014 at 3:17 PM, Pavel Stehule <
> pavel.steh...@gmail.com>
> > > wrote:
> >
> > > > important is a placing in --help
On Fri, Feb 28, 2014 at 3:44 PM, Alvaro Herrera
wrote:
>
> Fabrízio de Royes Mello escribió:
> > On Fri, Feb 28, 2014 at 3:17 PM, Pavel Stehule
> > wrote:
>
> > > important is a placing in --help output
> >
> > Well, then we just have to add more info to --help
>
> I think psql could do with som
Fabrízio de Royes Mello escribió:
> On Fri, Feb 28, 2014 at 3:17 PM, Pavel Stehule
> wrote:
> > important is a placing in --help output
>
> Well, then we just have to add more info to --help
I think psql could do with some lines for the possible options for
--pset (14) and --variable (13). No
2014-02-28 19:25 GMT+01:00 Fabrízio de Royes Mello
:
>
> On Fri, Feb 28, 2014 at 3:17 PM, Pavel Stehule
> wrote:
> >
> > 2014-02-28 19:13 GMT+01:00 Tom Lane :
> >
> >> Pavel Stehule writes:
> >> > for beginners is relative difficult to set psql variable from command
> line
> >> > and option
> >
On Fri, Feb 28, 2014 at 3:17 PM, Pavel Stehule
wrote:
>
> 2014-02-28 19:13 GMT+01:00 Tom Lane :
>
>> Pavel Stehule writes:
>> > for beginners is relative difficult to set psql variable from command
line
>> > and option
>> > -v ON_ERROR_STOP=1 is little bit unclean.
>> > and for any user it is not
2014-02-28 19:13 GMT+01:00 Tom Lane :
> Pavel Stehule writes:
> > for beginners is relative difficult to set psql variable from command
> line
> > and option
> > -v ON_ERROR_STOP=1 is little bit unclean.
> > and for any user it is not comfortable. So I propose a new psql option
> > --on-error-sto
Pavel Stehule writes:
> for beginners is relative difficult to set psql variable from command line
> and option
> -v ON_ERROR_STOP=1 is little bit unclean.
> and for any user it is not comfortable. So I propose a new psql option
> --on-error-stop
That saves a whole three characters ... not sure i
Hello
for beginners is relative difficult to set psql variable from command line
and option
-v ON_ERROR_STOP=1 is little bit unclean.
and for any user it is not comfortable. So I propose a new psql option
--on-error-stop
It is clean, and it will be mentioned in psql --help.
Comments, ideas?
69 matches
Mail list logo
