Re: [HACKERS] popen and pclose redefinitions causing many warning in Windows build

2014-05-15 Thread Michael Paquier
On Thu, May 15, 2014 at 6:20 PM, Heikki Linnakangas wrote: > Ok, I committed #undefs. I don't have a Mingw(-w64) environment to test > with, so let's see if the buildfarm likes it. There does not seem to be a buildfarm machine using MinGW-w64... Btw, I tested latest master on a Windows box and Min

Re: [HACKERS] popen and pclose redefinitions causing many warning in Windows build

2014-05-08 Thread Andrew Dunstan
On 05/08/2014 12:14 PM, Tom Lane wrote: Andrew Dunstan writes: I'm pretty sure we need this on Mingw - this SYSTEMQUOTE stuff dates back well before 8.3, IIRC, which is when we first got full MSVC support. I tried googling for some info on this, and got a number of hits suggesting that mingw

Re: [HACKERS] popen and pclose redefinitions causing many warning in Windows build

2014-05-08 Thread Tom Lane
Andrew Dunstan writes: > I'm pretty sure we need this on Mingw - this SYSTEMQUOTE stuff dates > back well before 8.3, IIRC, which is when we first got full MSVC support. I tried googling for some info on this, and got a number of hits suggesting that mingw didn't emulate popen at all till pretty

Re: [HACKERS] popen and pclose redefinitions causing many warning in Windows build

2014-05-08 Thread Andrew Dunstan
On 05/08/2014 11:19 AM, Tom Lane wrote: Heikki Linnakangas writes: On 05/08/2014 08:01 AM, Michael Paquier wrote: Since commit a692ee5, code compilation on windows is full of warnings caused by the re-definitions of popen and pclose: Hmm. Does the MinGW version of popen() and system() do the

Re: [HACKERS] popen and pclose redefinitions causing many warning in Windows build

2014-05-08 Thread Tom Lane
Heikki Linnakangas writes: > On 05/08/2014 08:01 AM, Michael Paquier wrote: >> Since commit a692ee5, code compilation on windows is full of warnings >> caused by the re-definitions of popen and pclose: > Hmm. Does the MinGW version of popen() and system() do the quoting for > you? If we just #if

Re: [HACKERS] popen and pclose redefinitions causing many warning in Windows build

2014-05-08 Thread Heikki Linnakangas
On 05/08/2014 08:01 AM, Michael Paquier wrote: Hi all, Since commit a692ee5, code compilation on windows is full of warnings caused by the re-definitions of popen and pclose: In file included from ../../../src/include/c.h:1028:0, from ../../../src/include/postgres.h:47,

[HACKERS] popen and pclose redefinitions causing many warning in Windows build

2014-05-07 Thread Michael Paquier
Hi all, Since commit a692ee5, code compilation on windows is full of warnings caused by the re-definitions of popen and pclose: In file included from ../../../src/include/c.h:1028:0, from ../../../src/include/postgres.h:47, from analyze.c:25: ../../../src/include/