Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-08-11 Thread Bruce Momjian
Zdenek Kotala wrote: > Tom Lane napsal(a): > > Zdenek Kotala <[EMAIL PROTECTED]> writes: > >> I understand. However I have another dumb idea/question - It seems to me > >> that it > >> is client code. I think that it should be integrated into psql > >> command. > > > > That doesn't seem like a p

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-25 Thread Zdenek Kotala
Tom Lane napsal(a): Zdenek Kotala <[EMAIL PROTECTED]> writes: I understand. However I have another dumb idea/question - It seems to me that it is client code. I think that it should be integrated into psql command. That doesn't seem like a particularly appropriate thing to do ... nor do I see

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-24 Thread Peter Eisentraut
Am Wednesday, 23. July 2008 schrieb Zdenek Kotala: > Is it fixed only on head or do you plan to backported to older branch as > well? I don't see a need to backport this. The only difference is that now you will get an error if no tclsh is found. The call "configure TCLSH=..." is the same in a

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-23 Thread Tom Lane
Zdenek Kotala <[EMAIL PROTECTED]> writes: > I understand. However I have another dumb idea/question - It seems to me that > it > is client code. I think that it should be integrated into psql > command. That doesn't seem like a particularly appropriate thing to do ... nor do I see the argument f

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-23 Thread Zdenek Kotala
Tom Lane napsal(a): Zdenek Kotala <[EMAIL PROTECTED]> writes: Tom Lane napsal(a): Actually it looks like it's been a very long time since these scripts got any love anyway. There's no reason anymore to split modules into multiple rows (not since TOAST...) and they're not schema-safe either. An

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-23 Thread Zdenek Kotala
Peter Eisentraut napsal(a): Am Tuesday, 22. July 2008 schrieb Zdenek Kotala: By main opinion main problem is in build process which does not fail and also dependency on tclsh is hidden by exec command. Fixed. Now, configure will fail if no tcl shell is found. You can specify one with the TC

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-23 Thread Peter Eisentraut
Am Tuesday, 22. July 2008 schrieb Zdenek Kotala: > By main opinion main problem is in build process which does not fail and > also dependency on tclsh is hidden by exec command. Fixed. Now, configure will fail if no tcl shell is found. You can specify one with the TCLSH variable. -- Sent via

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-23 Thread Tom Lane
Zdenek Kotala <[EMAIL PROTECTED]> writes: > Tom Lane napsal(a): >> Actually it looks like it's been a very long time since these scripts >> got any love anyway. There's no reason anymore to split modules into >> multiple rows (not since TOAST...) and they're not schema-safe either. >> Anybody feel

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-23 Thread Zdenek Kotala
Tom Lane napsal(a): Peter Eisentraut <[EMAIL PROTECTED]> writes: By the way, these programs start with package require Pgtcl but we don't provide that library. Should that bother us? Hmm. The scripts actually depend on both pltcl and Pgtcl, so just pushing them out to the Pgtcl package would

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-23 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > By the way, these programs start with > package require Pgtcl > but we don't provide that library. Should that bother us? Hmm. The scripts actually depend on both pltcl and Pgtcl, so just pushing them out to the Pgtcl package wouldn't really improve

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-23 Thread Peter Eisentraut
Am Tuesday, 22. July 2008 schrieb Tom Lane: > Zdenek Kotala <[EMAIL PROTECTED]> writes: > > Yeah, I looked deeply on our solaris build script and problem is with > > following configure setup: > > > > ./configure --prefix=/tmp/pg --with-tcl --with-tclconfig=/usr/sfw/lib > > > > It found tclconfig,

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-22 Thread Tom Lane
Zdenek Kotala <[EMAIL PROTECTED]> writes: > Yeah, I looked deeply on our solaris build script and problem is with > following > configure setup: > ./configure --prefix=/tmp/pg --with-tcl --with-tclconfig=/usr/sfw/lib > It found tclconfig, but not tclsh Ah. So actually there is a bug in our co

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-22 Thread Andrew Dunstan
Tom Lane wrote: Zdenek Kotala <[EMAIL PROTECTED]> writes: But problem is also in configure which does not fail when tclsh is not found. Yes it does ... if test $[#] -eq 0; then test -z "$TCLSH" && AC_MSG_ERROR([unable to locate tclConfig.sh because no Tcl shell was foun

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-22 Thread Zdenek Kotala
Tom Lane napsal(a): Zdenek Kotala <[EMAIL PROTECTED]> writes: But problem is also in configure which does not fail when tclsh is not found. Yes it does ... if test $[#] -eq 0; then test -z "$TCLSH" && AC_MSG_ERROR([unable to locate tclConfig.sh because no Tcl shell was found])

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-22 Thread Tom Lane
Zdenek Kotala <[EMAIL PROTECTED]> writes: > But problem is also in configure which does not fail when tclsh is not > found. Yes it does ... if test $[#] -eq 0; then test -z "$TCLSH" && AC_MSG_ERROR([unable to locate tclConfig.sh because no Tcl shell was found])

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-22 Thread Zdenek Kotala
Tom Lane napsal(a): Zdenek Kotala <[EMAIL PROTECTED]> writes: Commands pltcl_listmod, pltcl_delmod, pltcl_loadmod does not work on Solaris 10, because there is not present tclsh. Shouldn't this bug be filed against Solaris' clearly-broken tcl installation? I'm not able to make decision if t

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-22 Thread Tom Lane
Zdenek Kotala <[EMAIL PROTECTED]> writes: > Commands pltcl_listmod, pltcl_delmod, pltcl_loadmod does not work on Solaris > 10, > because there is not present tclsh. Shouldn't this bug be filed against Solaris' clearly-broken tcl installation? regards, tom lane -- Sent

Re: [HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-22 Thread Zdenek Kotala
Zdenek Kotala napsal(a): Commands pltcl_listmod, pltcl_delmod, pltcl_loadmod does not work on Solaris 10, because there is not present tclsh. I found that tclsh is available on solaris 10 in /usr/sfw/bin and its name is tclsh8.3. Zdenek -- Sent via pgsql-hackers mailing lis

[HACKERS] pltcl_*mod commands are broken on Solaris 10

2008-07-22 Thread Zdenek Kotala
Commands pltcl_listmod, pltcl_delmod, pltcl_loadmod does not work on Solaris 10, because there is not present tclsh. Unfortunately build process substitute path to shell with empty string which invokes infinite loop. See diff between S10 and Nevada: bash-3.00# head /usr/postgres/8.3/bin/pltcl