Re: [HACKERS] plpgsql compile error on win32

2004-07-31 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Ok. So the problem is that functions from libpgport aren't included in > postgres.def, and thus not in libpostgres.a. It seems that can be fixed > with the following patch, which is probably a whole lot close to being > right than what I did before:

Re: [HACKERS] plpgsql compile error on win32

2004-07-31 Thread Magnus Hagander
>> pg_strcasecmp is *not* included in libpostgres.a. It is in >> port/libpgport.a, though. (It's also in postgres.exe, but we >don't link >> against that..) > >What do you mean we don't link against that? There must be hundreds of >functions in the main backend that plpgsql.dll needs to call. H

Re: [HACKERS] plpgsql compile error on win32

2004-07-31 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > pg_strcasecmp is *not* included in libpostgres.a. It is in > port/libpgport.a, though. (It's also in postgres.exe, but we don't link > against that..) What do you mean we don't link against that? There must be hundreds of functions in the main back

Re: [HACKERS] plpgsql compile error on win32

2004-07-31 Thread Magnus Hagander
>> With the latest commits, plpgsql no longer compiles on >win32, because of >> a link failure to pg_strcasecmp(). > >That doesn't make any sense. It should resolve it as a function in the >backend. Why isn't that happening? Dunno... Build output without my fix is: dlltool --export-all --outp

Re: [HACKERS] plpgsql compile error on win32

2004-07-31 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > With the latest commits, plpgsql no longer compiles on win32, because of > a link failure to pg_strcasecmp(). That doesn't make any sense. It should resolve it as a function in the backend. Why isn't that happening? regards

[HACKERS] plpgsql compile error on win32

2004-07-31 Thread Magnus Hagander
With the latest commits, plpgsql no longer compiles on win32, because of a link failure to pg_strcasecmp(). I fixed this locally by adding "-lpgport" to SHLIB_LINK in the makefile in pl/plpgsql/src, but I'm not sure if that is the correct long-term fix? //Magnus ---(end