On Thu, May 24, 2012 at 12:03 PM, Peter Eisentraut wrote:
> On tor, 2012-05-24 at 11:36 -0600, Alex Hunsaker wrote:
>> Doh, it is indeed there in 5.16.0, looks like it got added in 5.10
>> :-(. (I was on the wrong branch...).
>
> It's in ppport.h.
Don't see any reason not to then. +1 for the sim
On tor, 2012-05-24 at 11:36 -0600, Alex Hunsaker wrote:
> On Thu, May 24, 2012 at 11:31 AM, Alex Hunsaker wrote:
> > On Thu, May 24, 2012 at 11:19 AM, Peter Eisentraut wrote:
> >>
> >> And we could use SvREFCNT_inc_simple_void(sv), since sv doesn't have any
> >> side effects, but that's optional.
On Thu, May 24, 2012 at 11:31 AM, Alex Hunsaker wrote:
> On Thu, May 24, 2012 at 11:19 AM, Peter Eisentraut wrote:
>>
>> And we could use SvREFCNT_inc_simple_void(sv), since sv doesn't have any
>> side effects, but that's optional.
> Hrm I can't seem to find either of those functions in my copy
On Thu, May 24, 2012 at 11:19 AM, Peter Eisentraut wrote:
> clang warns about that newish SvREFCNT_inc(sv) call in plperl_helpers.h
> about an unused return value, because the macro expansion of
> SvREFCNT_inc(sv) returns sv. The merit of that warning might be
> debatable, but it seems easy to fi
clang warns about that newish SvREFCNT_inc(sv) call in plperl_helpers.h
about an unused return value, because the macro expansion of
SvREFCNT_inc(sv) returns sv. The merit of that warning might be
debatable, but it seems easy to fix by using SvREFCNT_inc_void(sv)
instead.
And we could use SvREFCN
