Re: [HACKERS] pgxs: build infrastructure for extensions v4

2004-08-06 Thread Bruce Momjian
Oh, I see that modification now. Thanks. Sorry I missed it. --- Joe Conway wrote: > Bruce Momjian wrote: > > FYI, I couldn't find anything in the shell pg_config with this path: > > > > strncat(otherpath, "/pgxs/s

Re: [HACKERS] pgxs: build infrastructure for extensions v4

2004-08-05 Thread Joe Conway
Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: FYI, I couldn't find anything in the shell pg_config with this path: strncat(otherpath, "/pgxs/src/makefiles/pgxs.mk", MAXPGPATH-1); Did you find a mention of this? I looked in pg_config.sh and Makefile.global.in. The original codin

Re: [HACKERS] pgxs: build infrastructure for extensions v4

2004-08-05 Thread Joe Conway
Bruce Momjian wrote: FYI, I couldn't find anything in the shell pg_config with this path: strncat(otherpath, "/pgxs/src/makefiles/pgxs.mk", MAXPGPATH-1); Did you find a mention of this? I looked in pg_config.sh and Makefile.global.in. I see it here: http://developer.postgresql.org/cvsweb.c

Re: [HACKERS] pgxs: build infrastructure for extensions v4

2004-08-05 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > FYI, I couldn't find anything in the shell pg_config with this path: > strncat(otherpath, "/pgxs/src/makefiles/pgxs.mk", MAXPGPATH-1); > Did you find a mention of this? I looked in pg_config.sh and > Makefile.global.in. The original coding conca

Re: [HACKERS] pgxs: build infrastructure for extensions v4

2004-08-05 Thread Bruce Momjian
FYI, I couldn't find anything in the shell pg_config with this path: strncat(otherpath, "/pgxs/src/makefiles/pgxs.mk", MAXPGPATH-1); Did you find a mention of this? I looked in pg_config.sh and Makefile.global.in. I am not saying your change is wrong, just that it is new, I think. ---

Re: [HACKERS] pgxs: build infrastructure for extensions v4

2004-08-04 Thread Joe Conway
Andrew Dunstan wrote: Mark Cave-Ayland wrote: This is because I only get the pgxs directory returned by "pgconfig --pgxs" as opposed to the path to the pgxs.mk file itself - is that the correct thing to do (i.e. the comment is wrong?) or is "pgconfig --pgxs" returning the wrong thing? needs to be f

Re: [HACKERS] pgxs: build infrastructure for extensions v4

2004-08-04 Thread Andrew Dunstan
Mark Cave-Ayland wrote: Peter/Fabien, Just to say thank you for all your hard work in getting pgxs working in CVS. I've successfully managed to get a contrib module to build outside of the source tree, which will help simplify a lot of things. I have one question though: the comments in pgxs.mk su

Re: [HACKERS] pgxs: build infrastructure for extensions v4

2004-08-04 Thread Mark Cave-Ayland
Peter/Fabien, Just to say thank you for all your hard work in getting pgxs working in CVS. I've successfully managed to get a contrib module to build outside of the source tree, which will help simplify a lot of things. I have one question though: the comments in pgxs.mk suggested that I needed t

Re: [HACKERS] pgxs: build infrastructure for extensions v4

2004-08-03 Thread Bruce Momjian
Tom Lane wrote: > Joe Conway <[EMAIL PROTECTED]> writes: > > One question did arise, however. In order to use pgxs I needed to do: > >make install-all-headers > > instead of: > >make install > > > I seem to recall some discussion about this, but at the time didn't > > realize the impact.

Re: [HACKERS] pgxs: build infrastructure for extensions v4

2004-08-03 Thread Christopher Kings-Lynne
However, we could certainly talk about altering the default behavior (eg, install becomes install-no-headers and install-all-headers becomes part of the default install target). Seems like a good idea to me. Chris ---(end of broadcast)--- TIP 9: the p

Re: [HACKERS] pgxs: build infrastructure for extensions v4

2004-08-03 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > One question did arise, however. In order to use pgxs I needed to do: >make install-all-headers > instead of: >make install > I seem to recall some discussion about this, but at the time didn't > realize the impact. IMHO pgxs support (including all

Re: [HACKERS] pgxs: build infrastructure for extensions v4

2004-08-03 Thread Peter Eisentraut
Joe Conway wrote: > One question did arise, however. In order to use pgxs I needed to do: >make install-all-headers > instead of: >make install Yes, I forgot to mention that the install targets still need to be sorted out. FWIW, I've always been in favor of installing everything all the

Re: [HACKERS] pgxs: build infrastructure for extensions v4

2004-08-03 Thread Joe Conway
Peter Eisentraut wrote: Am Freitag, 16. Juli 2004 16:34 schrieb Fabien COELHO: Please find attached another new version of a patch which provides a working infrastructure for pg extensions. I hope it addresses all of Peter's comments. I'll be away for the next 3 weeks, so if minor changes are requi