Re: [HACKERS] pg_upgrade: make the locale comparison more tolerating

2014-01-30 Thread Tom Lane
Pavel Raiskup writes: > [ 0001-pg_upgrade-make-the-locale-comparison-more-toleratin.patch ] Committed with minor adjustments (mostly, wordsmithing the comments). Although this was categorized as a bug fix, I'm not sure it's worth taking the risk of back-patching. We've not seen very many report

Re: [HACKERS] pg_upgrade: make the locale comparison more tolerating

2014-01-30 Thread Rushabh Lathia
Hi Pavel, I looked at your latest cleanup patch. Yes its looks more cleaner in term equivalent_locale & equivalent_encoding separate functions. I did run the test again on latest patch and all looks good. Marking it as ready for committer. Regards, On Fri, Jan 24, 2014 at 9:49 PM, Pavel Rais

Re: [HACKERS] pg_upgrade: make the locale comparison more tolerating

2014-01-24 Thread Pavel Raiskup
Rushabh, really sorry I have to re-create the patch and thanks a lot for looking at it! Looking at the patch once again, I see that there were at least two problems. Firstly, I used the equivalent_locale function also on the encoding values. Even if that should not cause bugs (as it should resul

Re: [HACKERS] pg_upgrade: make the locale comparison more tolerating

2014-01-24 Thread Rushabh Lathia
Hello, I started reviewing the patch. Go through the original mail thread to understand the need of fix and the actual problem. http://www.postgresql.org/message-id/20121002155857.ge30...@momjian.us Patch is using pg_valid_server_encoding() to compare the encoding which looks more correct. Did c