Re: [HACKERS] pg_signal_backend() asymmetry

2012-09-27 Thread Alvaro Herrera
Excerpts from Noah Misch's message of mié sep 26 17:54:43 -0300 2012: > I'm marking this patch Ready for Committer. I suggest backpatching it to 9.2; > the patch corrects an oversight in 9.2 changes. There's more compatibility > value in backpatching than in retaining distinct behavior for 9.2 on

Re: [HACKERS] pg_signal_backend() asymmetry

2012-09-26 Thread Noah Misch
I'm marking this patch Ready for Committer. I suggest backpatching it to 9.2; the patch corrects an oversight in 9.2 changes. There's more compatibility value in backpatching than in retaining distinct behavior for 9.2 only. On Thu, Jun 28, 2012 at 09:32:41AM -0700, Josh Kupershmidt wrote: > !

Re: [HACKERS] pg_signal_backend() asymmetry

2012-06-28 Thread Josh Kupershmidt
On Thu, Jun 28, 2012 at 6:48 AM, Noah Misch wrote: > On Thu, Jun 28, 2012 at 01:36:49AM -0700, Daniel Farina wrote: >> On Wed, Jun 27, 2012 at 5:38 PM, Josh Kupershmidt wrote: >> > I have one nitpick related to the recent changes for >> > pg_cancel_backend() and pg_terminate_backend(). If you use

Re: [HACKERS] pg_signal_backend() asymmetry

2012-06-28 Thread Noah Misch
On Thu, Jun 28, 2012 at 01:36:49AM -0700, Daniel Farina wrote: > On Wed, Jun 27, 2012 at 5:38 PM, Josh Kupershmidt wrote: > > I have one nitpick related to the recent changes for > > pg_cancel_backend() and pg_terminate_backend(). If you use these > > functions as an unprivileged user, and try to

Re: [HACKERS] pg_signal_backend() asymmetry

2012-06-28 Thread Magnus Hagander
On Thu, Jun 28, 2012 at 10:36 AM, Daniel Farina wrote: > On Wed, Jun 27, 2012 at 5:38 PM, Josh Kupershmidt wrote: >> Hi all, >> >> I have one nitpick related to the recent changes for >> pg_cancel_backend() and pg_terminate_backend(). If you use these >> functions as an unprivileged user, and try

Re: [HACKERS] pg_signal_backend() asymmetry

2012-06-28 Thread Daniel Farina
On Wed, Jun 27, 2012 at 5:38 PM, Josh Kupershmidt wrote: > Hi all, > > I have one nitpick related to the recent changes for > pg_cancel_backend() and pg_terminate_backend(). If you use these > functions as an unprivileged user, and try to signal a nonexistent > PID, you get: I think the goal ther

[HACKERS] pg_signal_backend() asymmetry

2012-06-27 Thread Josh Kupershmidt
Hi all, I have one nitpick related to the recent changes for pg_cancel_backend() and pg_terminate_backend(). If you use these functions as an unprivileged user, and try to signal a nonexistent PID, you get: ERROR: must be superuser or have the same role to cancel queries running in other serve