Re: [HACKERS] pg_settings.enumval as array

2008-11-21 Thread Magnus Hagander
Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: >>> Also, the output datatype should be text[] not cstring[]. > >> Ok, will change. That requires hardcode of 1009? Or should I a #define >> to pg_type.h? > > Add a #define (bit surprising we didn't have one already)

Re: [HACKERS] pg_settings.enumval as array

2008-11-21 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Also, the output datatype should be text[] not cstring[]. > Ok, will change. That requires hardcode of 1009? Or should I a #define > to pg_type.h? Add a #define (bit surprising we didn't have one already) re

Re: [HACKERS] pg_settings.enumval as array

2008-11-21 Thread Magnus Hagander
Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: >> The attached patch changes pg_settings.enumval to be an array of text >> instead of just a string, per previous discussion and the open items list. > >> Comments? > > Hmmm ... this coding will fail if any enumval contains a double q

Re: [HACKERS] pg_settings.enumval as array

2008-11-21 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > The attached patch changes pg_settings.enumval to be an array of text > instead of just a string, per previous discussion and the open items list. > Comments? Hmmm ... this coding will fail if any enumval contains a double quote. Which is probably not

[HACKERS] pg_settings.enumval as array

2008-11-21 Thread Magnus Hagander
The attached patch changes pg_settings.enumval to be an array of text instead of just a string, per previous discussion and the open items list. Comments? //Magnus *** a/src/backend/utils/misc/guc.c --- b/src/backend/utils/misc/guc.c *** *** 168,174 static bool assign_maxconnecti