Re: [HACKERS] pg_regress writes into source tree

2015-04-07 Thread Michael Paquier
On Wed, Apr 8, 2015 at 10:28 AM, Jim Nasby wrote: > Just so this doesn't get lost... did something make it into a CommitFest on > this? Peter's patch has been committed as 64cdbbc, while the idea to create sql/ by pg_regress if it is not present did not gather much interest in this CF: https://com

Re: [HACKERS] pg_regress writes into source tree

2015-04-07 Thread Jim Nasby
On 2/13/15 11:20 PM, Michael Paquier wrote: On Sat, Feb 14, 2015 at 6:24 AM, Andrew Dunstan wrote: On 12/18/2014 06:05 PM, Andrew Dunstan wrote: On 12/18/2014 03:02 AM, Michael Paquier wrote: On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera wrote: Another thing in that patch was that I

Re: [HACKERS] pg_regress writes into source tree

2015-02-13 Thread Michael Paquier
On Sat, Feb 14, 2015 at 6:24 AM, Andrew Dunstan wrote: > > On 12/18/2014 06:05 PM, Andrew Dunstan wrote: >> >> >> On 12/18/2014 03:02 AM, Michael Paquier wrote: >>> >>> On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera >>> wrote: >>> Another thing in that patch was that I had to add the sql/

Re: [HACKERS] pg_regress writes into source tree

2015-02-13 Thread Andrew Dunstan
On 12/18/2014 06:05 PM, Andrew Dunstan wrote: On 12/18/2014 03:02 AM, Michael Paquier wrote: On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera wrote: Another thing in that patch was that I had to add the sql/ directory to the source tree, but other than that .gitignore file it was empty. May

Re: [HACKERS] pg_regress writes into source tree

2014-12-18 Thread Andrew Dunstan
On 12/18/2014 03:02 AM, Michael Paquier wrote: On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera wrote: Another thing in that patch was that I had to add the sql/ directory to the source tree, but other than that .gitignore file it was empty. Maybe pg_regress should create the sql/ directory i

Re: [HACKERS] pg_regress writes into source tree

2014-12-18 Thread Michael Paquier
On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera wrote: > Another thing in that patch was that I had to add the sql/ directory to > the source tree, but other than that .gitignore file it was empty. > Maybe pg_regress should create the sql/ directory in the build dir if it > doesn't exist. This

Re: [HACKERS] pg_regress writes into source tree

2014-12-17 Thread Andres Freund
Hi, On 2014-12-11 22:02:26 -0500, Peter Eisentraut wrote: > When using a vpath build pg_regress writes the processed input/*.source > files into the *source* tree, which isn't supposed to happen. > > This appears to be a thinko introduced in this patch: > e3fc4a97bc8ee82a78605b5ffe79bd4cf3c6213b

Re: [HACKERS] pg_regress writes into source tree

2014-12-12 Thread Alvaro Herrera
Peter Eisentraut wrote: > When using a vpath build pg_regress writes the processed input/*.source > files into the *source* tree, which isn't supposed to happen. > > This appears to be a thinko introduced in this patch: > e3fc4a97bc8ee82a78605b5ffe79bd4cf3c6213b Oh, I noticed this while doing the

[HACKERS] pg_regress writes into source tree

2014-12-11 Thread Peter Eisentraut
When using a vpath build pg_regress writes the processed input/*.source files into the *source* tree, which isn't supposed to happen. This appears to be a thinko introduced in this patch: e3fc4a97bc8ee82a78605b5ffe79bd4cf3c6213b The attached patch fixes it. diff --git a/src/test/regress/pg_regres