Re: [HACKERS] pg_migrator versus inherited columns

2009-07-01 Thread Greg Stark
On Thu, Jul 2, 2009 at 1:25 AM, Tom Lane wrote: > > Hmm, 8.3 doesn't seem to recognize the syntax: > > regression=# alter table c add inherit p; > ERROR:  type "p" does not exist > LINE 1: alter table c add inherit p; >                                  ^ Oh I remember being caught by this myself.

Re: [HACKERS] pg_migrator versus inherited columns

2009-07-01 Thread Tom Lane
Greg Stark writes: > On Wed, Jul 1, 2009 at 11:36 PM, Tom Lane wrote: >> Comments? > Uhm, we've had ADD INHERIT since 8.2 -- that was my first patch. Hmm, 8.3 doesn't seem to recognize the syntax: regression=# alter table c add inherit p; ERROR: type "p" does not exist LINE 1: alter table c ad

Re: [HACKERS] pg_migrator versus inherited columns

2009-07-01 Thread Greg Stark
On Wed, Jul 1, 2009 at 11:36 PM, Tom Lane wrote: > (It's a good thing we added ADD INHERIT in 8.4, or we'd be completely > up the creek here.)  In this way we can ensure that the physical order > of columns really is what it needs to be in the child table.  Dropped > columns can then be managed in

[HACKERS] pg_migrator versus inherited columns

2009-07-01 Thread Tom Lane
I was testing pg_migrator the other day on the regression database, and found out that it doesn't work: Restoring database schema psql:/home/postgres/pg_migrator_dump_db.sql:4545: ERROR: column "pg.dropped.1" of relation "dropcolumnchild" does n