Re: [HACKERS] pg_dump.c

2011-09-11 Thread Rob Wultsch
On Sun, Sep 11, 2011 at 9:18 AM, Andrew Dunstan wrote: > > > On 09/11/2011 10:25 AM, David Fetter wrote: >> >> On Thu, Sep 08, 2011 at 03:20:14PM -0400, Andrew Dunstan wrote: >>> >>> In the "refactoring Large C files" discussion one of the biggest >>> files Bruce mentioned is pg_dump.c. There has

Re: [HACKERS] pg_dump.c

2011-09-11 Thread Andrew Dunstan
On 09/11/2011 02:50 PM, Tom Lane wrote: In particular, I think that discovering a safe dump order for a selected set of objects is a pretty key portion of pg_dump's functionality. Do we really want to assume that that needn't be included in a hypothetical library? Maybe. Who else would need i

Re: [HACKERS] pg_dump.c

2011-09-11 Thread Tom Lane
Andrew Dunstan writes: > One example of what I'd like to provide is something this: > char * pg_get_create_sql(PGconn *conn, object oid, catalog_class > oid, pretty boolean); > Which would give you the sql to create an object, optionally pretty > printing it. I think the major problem wi

Re: [HACKERS] pg_dump.c

2011-09-11 Thread Andrew Dunstan
On 09/11/2011 10:25 AM, David Fetter wrote: On Thu, Sep 08, 2011 at 03:20:14PM -0400, Andrew Dunstan wrote: In the "refactoring Large C files" discussion one of the biggest files Bruce mentioned is pg_dump.c. There has been discussion in the past of turning lots of the knowledge currently embe

Re: [HACKERS] pg_dump.c

2011-09-11 Thread Robert Haas
On Thu, Sep 8, 2011 at 3:20 PM, Andrew Dunstan wrote: > In the "refactoring Large C files" discussion one of the biggest files Bruce > mentioned is pg_dump.c. There has been discussion in the past of turning > lots of the knowledge currently embedded in this file into a library, which > would make

Re: [HACKERS] pg_dump.c

2011-09-11 Thread David Fetter
On Thu, Sep 08, 2011 at 03:20:14PM -0400, Andrew Dunstan wrote: > > In the "refactoring Large C files" discussion one of the biggest > files Bruce mentioned is pg_dump.c. There has been discussion in the > past of turning lots of the knowledge currently embedded in this > file into a library, whic

Re: [HACKERS] pg_dump.c

2011-09-08 Thread Pavel Golub
Hello, Andrew. You wrote: AD> In the "refactoring Large C files" discussion one of the biggest files AD> Bruce mentioned is pg_dump.c. There has been discussion in the past of AD> turning lots of the knowledge currently embedded in this file into a AD> library, which would make it available to

[HACKERS] pg_dump.c

2011-09-08 Thread Andrew Dunstan
In the "refactoring Large C files" discussion one of the biggest files Bruce mentioned is pg_dump.c. There has been discussion in the past of turning lots of the knowledge currently embedded in this file into a library, which would make it available to other clients (e.g. psql). I'm not sure