Re: [HACKERS] pg_dump reporing version of server & pg_dump as comments in the output

Jeevan Chalke writes: > Can't we remove this else all-together and print extra line unconditionally? > Also can we remove curly braces in if and else near these code changes ? > (Attached patch along those lines) I committed this with slight further rearrangement to create what seems like better

Re: [HACKERS] pg_dump reporing version of server & pg_dump as comments in the output

At 2014-06-17 13:21:34 +0530, jeevan.cha...@enterprisedb.com wrote: > > Anyone has any other views ? I guess nobody has strong feelings either way. I've marked this (i.e. your slightly-revised patch) ready for committer. -- Abhijit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgres

Re: [HACKERS] pg_dump reporing version of server & pg_dump as comments in the output

On Tue, Mar 4, 2014 at 11:28 AM, Wang, Jing wrote: > >I don't buy your argument. Why isn't verbose option sufficient? Did you > read the old thread about this [1]? > >[1] http://www.postgresql.org/message-id/3677.1253912...@sss.pgh.pa.us > > >AFAICS a lot of people compare pg_dump diffs. If we ap

Re: [HACKERS] pg_dump reporing version of server & pg_dump as comments in the output

On 4 March 2014 2:41 Euler Taveira wrote: >On 27-02-2014 21:10, Wang, Jing wrote: >> Using pg_dump can dump the data into the file with format set to be >> 'c','t' or plain text. In the existing version the version of server & >> pg_dump is already there when the format of file is 'c' or 't'. And

Re: [HACKERS] pg_dump reporing version of server & pg_dump as comments in the output

On 27-02-2014 21:10, Wang, Jing wrote: > Using pg_dump can dump the data into the file with format set to be > 'c','t' or plain text. In the existing version the version of server & > pg_dump is already there when the format of file is 'c' or 't'. And even > for the plain text format file the versi

Re: [HACKERS] pg_dump reporing version of server & pg_dump as comments in the output

Sorry for missing the patch file in the original email. Enclosed please find it. Jing Wang Fujitsu Australia From: Arulappan, Arul Shaji Sent: Friday, 28 February 2014 11:21 AM To: Wang, Jing Subject: RE: [HACKERS] pg_dump reporing version of server & pg_dump as comments in

[HACKERS] pg_dump reporing version of server & pg_dump as comments in the output

Enclosed is the patch to implement the requirement that pg_dump should report version of server & pg_dump as comments in the output. [Benefit] By running "head" on pg_dump output, you can readily discover what version of PostgreSQL was used to generate that dump. Very useful especially for "m