Re: [HACKERS] pg_dump and insert multi-rows option

2007-09-14 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Andrew Dunstan wrote: > > > Tom Lane wrote: > > David Fetter <[EMAIL PROTECTED]> writes: > > > >> On Tue, Sep 04

Re: [HACKERS] pg_dump and insert multi-rows option

2007-09-04 Thread Bruce Momjian
Tom Lane wrote: > David Fetter <[EMAIL PROTECTED]> writes: > > On Tue, Sep 04, 2007 at 01:22:01PM -0400, Tom Lane wrote: > >> ... The only reason I can see to > >> use these options today is if you want to try to port the dump to > >> some other database ... and in that case you probably shouldn't

Re: [HACKERS] pg_dump and insert multi-rows option

2007-09-04 Thread Andrew Dunstan
Tom Lane wrote: David Fetter <[EMAIL PROTECTED]> writes: On Tue, Sep 04, 2007 at 01:22:01PM -0400, Tom Lane wrote: ... The only reason I can see to use these options today is if you want to try to port the dump to some other database ... and in that case you probably shouldn't assume

Re: [HACKERS] pg_dump and insert multi-rows option

2007-09-04 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: > On Tue, Sep 04, 2007 at 01:22:01PM -0400, Tom Lane wrote: >> ... The only reason I can see to >> use these options today is if you want to try to port the dump to >> some other database ... and in that case you probably shouldn't >> assume multi-insert wil

Re: [HACKERS] pg_dump and insert multi-rows option

2007-09-04 Thread David Fetter
On Tue, Sep 04, 2007 at 01:22:01PM -0400, Tom Lane wrote: > =?iso-8859-15?q?C=E9dric_Villemain?= <[EMAIL PROTECTED]> writes: > > Well, I can only make a new ask. Why is there the --inserts and > > --attribute-inserts options ? > > It's mostly historical IMHO. The COPY option used to have bugs fo

Re: [HACKERS] pg_dump and insert multi-rows option

2007-09-04 Thread Tom Lane
=?iso-8859-15?q?C=E9dric_Villemain?= <[EMAIL PROTECTED]> writes: > Well, I can only make a new ask. > Why is there the --inserts and --attribute-inserts options ? It's mostly historical IMHO. The COPY option used to have bugs for corner cases like inheritance child tables that had been ALTERed af

Re: [HACKERS] pg_dump and insert multi-rows option

2007-09-04 Thread Cédric Villemain
Le mardi 4 septembre 2007, Tom Lane a écrit : > =?utf-8?q?C=C3=A9dric_Villemain?= <[EMAIL PROTECTED]> writes: > > In order to make some trivial test, I have start patching pg_dump to > > get=20 insert using multi-rows (like --inserts option). > > Why? COPY is faster and won't have issues for very

Re: [HACKERS] pg_dump and insert multi-rows option

2007-09-04 Thread Tom Lane
=?utf-8?q?C=C3=A9dric_Villemain?= <[EMAIL PROTECTED]> writes: > In order to make some trivial test, I have start patching pg_dump to get=20 > insert using multi-rows (like --inserts option). Why? COPY is faster and won't have issues for very large numbers of rows. regards

[HACKERS] pg_dump and insert multi-rows option

2007-09-04 Thread Cédric Villemain
Hello, In order to make some trivial test, I have start patching pg_dump to get insert using multi-rows (like --inserts option). I say "start" because it was just a poor hack to pg_dump.c. If you are interested I can finish it, and try to get a code that feet postgresql guidelines ? -- Cédri