Re: [HACKERS] pg_dump/pg_restore seem broken on hamerkop

2014-11-27 Thread Bruce Momjian
On Sun, Oct 26, 2014 at 08:29:19PM -0400, Tom Lane wrote: > I wrote: > > Hm. %z ought not be locale-dependent ... however, it has a bigger > > problem, which is that it's a C99-ism. It's not there in SUSv2, > > which is our normal baseline for what's portable. I think we need > > to get rid of t

Re: [HACKERS] pg_dump/pg_restore seem broken on hamerkop

2014-10-29 Thread Andrew Dunstan
On 10/29/2014 12:26 AM, Tom Lane wrote: I wrote: Alvaro Herrera writes: [Some more code and git-log reading later] I see that the %z is a very recent addition: it only got there as of commit ad5d46a449, of September 5th ... and now I also see that hamerkop's last green run before the failure

Re: [HACKERS] pg_dump/pg_restore seem broken on hamerkop

2014-10-28 Thread Tom Lane
I wrote: > Alvaro Herrera writes: >> [Some more code and git-log reading later] I see that the %z is a very >> recent addition: it only got there as of commit ad5d46a449, of September >> 5th ... and now I also see that hamerkop's last green run before the >> failure, on Oct 13rd, did *not* includ

Re: [HACKERS] pg_dump/pg_restore seem broken on hamerkop

2014-10-26 Thread Tom Lane
I wrote: > Hm. %z ought not be locale-dependent ... however, it has a bigger > problem, which is that it's a C99-ism. It's not there in SUSv2, > which is our normal baseline for what's portable. I think we need > to get rid of that. %Z should be portable. > (Is it possible that Windows' strfti

Re: [HACKERS] pg_dump/pg_restore seem broken on hamerkop

2014-10-26 Thread Tom Lane
Alvaro Herrera writes: > So this seems related to the %z part of the strftime() call. I have no > explanation for this failure ATM; maybe pg_restore is failing to set the > locale properly? I also notice pg_restore.c previously included > pg_backup_archiver.h (which in turn includes ); strftime

Re: [HACKERS] pg_dump/pg_restore seem broken on hamerkop

2014-10-26 Thread Alvaro Herrera
Tatsuo Ishii wrote: > > Buildfarm member hamerkop has been failing in the pg_upgrade regression > > test for the last several days. The problem looks like this: > > > > command: > > "C:/buildfarm/build_root/HEAD/pgsql.build/contrib/pg_upgrade/tmp_check/install/bin/pg_restore" > > --port 50432 -

Re: [HACKERS] pg_dump/pg_restore seem broken on hamerkop

2014-10-26 Thread Tatsuo Ishii
>> Buildfarm member hamerkop has been failing in the pg_upgrade regression >> test for the last several days. The problem looks like this: >> >> command: >> "C:/buildfarm/build_root/HEAD/pgsql.build/contrib/pg_upgrade/tmp_check/install/bin/pg_restore" >> --port 50432 --username "Administrator"

Re: [HACKERS] pg_dump/pg_restore seem broken on hamerkop

2014-10-20 Thread Tatsuo Ishii
> Buildfarm member hamerkop has been failing in the pg_upgrade regression > test for the last several days. The problem looks like this: > > command: > "C:/buildfarm/build_root/HEAD/pgsql.build/contrib/pg_upgrade/tmp_check/install/bin/pg_restore" > --port 50432 --username "Administrator" --exit

[HACKERS] pg_dump/pg_restore seem broken on hamerkop

2014-10-19 Thread Tom Lane
Buildfarm member hamerkop has been failing in the pg_upgrade regression test for the last several days. The problem looks like this: command: "C:/buildfarm/build_root/HEAD/pgsql.build/contrib/pg_upgrade/tmp_check/install/bin/pg_restore" --port 50432 --username "Administrator" --exit-on-error --