Re: [HACKERS] pg_dump(all) --quote-all-identifiers

2010-07-21 Thread Robert Haas
On Sat, Jul 17, 2010 at 3:59 AM, Alex Hunsaker wrote: > Patch looks and tests good to me.  Only thing that seemed to be > missing was documentation of the new pg_dump(all) and guc params. > Find attached a stab at this.  Yeah the docs I added need work, but I > figure if you are anything like me i

Re: [HACKERS] pg_dump(all) --quote-all-identifiers

2010-07-17 Thread Alex Hunsaker
On Sun, Jun 13, 2010 at 18:35, Robert Haas wrote: *Waves* Hi! Patch looks and tests good to me. Only thing that seemed to be missing was documentation of the new pg_dump(all) and guc params. Find attached a stab at this. Yeah the docs I added need work, but I figure if you are anything like me

Re: [HACKERS] pg_dump(all) --quote-all-identifiers

2010-06-14 Thread Tom Lane
Robert Haas writes: > On Mon, Jun 14, 2010 at 6:57 AM, Bruce Momjian wrote: >> Uh, I thought this was about quoting the identifiers.  I am confused >> about why "integer" is an issue in this case.  Can you show an example? > Sure. INTEGER is actually a keyword in this context, not an identifier

Re: [HACKERS] pg_dump(all) --quote-all-identifiers

2010-06-14 Thread Robert Haas
On Mon, Jun 14, 2010 at 6:57 AM, Bruce Momjian wrote: > Robert Haas wrote: >> In response to a complaint from Hartmut Goebel: >> >> http://archives.postgresql.org/pgsql-bugs/2010-06/msg00018.php >> >> And per a design proposed by Tom Lane: >> >> http://archives.postgresql.org/pgsql-bugs/2010-06/ms

Re: [HACKERS] pg_dump(all) --quote-all-identifiers

2010-06-14 Thread Bruce Momjian
Robert Haas wrote: > In response to a complaint from Hartmut Goebel: > > http://archives.postgresql.org/pgsql-bugs/2010-06/msg00018.php > > And per a design proposed by Tom Lane: > > http://archives.postgresql.org/pgsql-bugs/2010-06/msg00211.php > > PFA a patch to implement $SUBJECT. One inter

[HACKERS] pg_dump(all) --quote-all-identifiers

2010-06-13 Thread Robert Haas
In response to a complaint from Hartmut Goebel: http://archives.postgresql.org/pgsql-bugs/2010-06/msg00018.php And per a design proposed by Tom Lane: http://archives.postgresql.org/pgsql-bugs/2010-06/msg00211.php PFA a patch to implement $SUBJECT. One interesting aspect of this patch is that t