Re: [HACKERS] pg_do_encoding_conversion glitch

2008-11-10 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > Tom Lane <[EMAIL PROTECTED]> wrote: >> Do you have a proposal for a different API, or do you just want to >> improve the comment for the function? Bear in mind that a lot of the >> callers do know the string length, and so we shouldn't impose an >> un

Re: [HACKERS] pg_do_encoding_conversion glitch

2008-11-10 Thread ITAGAKI Takahiro
Tom Lane <[EMAIL PROTECTED]> wrote: > Do you have a proposal for a different API, or do you just want to > improve the comment for the function? Bear in mind that a lot of the > callers do know the string length, and so we shouldn't impose an > unnecessary strlen() operation on those cases. We

Re: [HACKERS] pg_do_encoding_conversion glitch

2008-11-10 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > I have a question about the result contract of pg_do_encoding_conversion(). It's poorly designed :-( As near as I can tell, all uses of the function either pass a null-terminated string or special-case the result == src case in such a way that it doe

[HACKERS] pg_do_encoding_conversion glitch

2008-11-10 Thread ITAGAKI Takahiro
I have a question about the result contract of pg_do_encoding_conversion(). It can receive non null-terminated string because its arguments are a char array and a byte length. And it only returns a string, so the string should be null-terminated. However, if conversions are not required, the funct