Re: [HACKERS] pg_basebackup and pg_stat_tmp directory

2014-02-03 Thread Fujii Masao
On Fri, Jan 31, 2014 at 9:29 PM, Fujii Masao wrote: > On Tue, Jan 28, 2014 at 5:51 PM, Magnus Hagander wrote: >> On Tue, Jan 28, 2014 at 6:11 AM, Amit Kapila >> wrote: >>> >>> On Tue, Jan 28, 2014 at 9:26 AM, Fujii Masao >>> wrote: >>> > Hi, >>> > >>> > The files in pg_stat_tmp directory don't

Re: [HACKERS] pg_basebackup and pg_stat_tmp directory

2014-02-02 Thread Fujii Masao
On Mon, Feb 3, 2014 at 6:57 AM, Peter Eisentraut wrote: > On 2/2/14, 10:23 AM, Fujii Masao wrote: >> I'm thinking to change basebackup.c so that it compares the >> name of the directory that it's trying to back up and the setting >> value of log_directory parameter, then, if they are the same, >>

Re: [HACKERS] pg_basebackup and pg_stat_tmp directory

2014-02-02 Thread Peter Eisentraut
On 2/2/14, 10:23 AM, Fujii Masao wrote: > I'm thinking to change basebackup.c so that it compares the > name of the directory that it's trying to back up and the setting > value of log_directory parameter, then, if they are the same, > it just skips the directory. The patch that I sent upthread doe

Re: [HACKERS] pg_basebackup and pg_stat_tmp directory

2014-02-02 Thread Fujii Masao
On Sat, Feb 1, 2014 at 2:08 AM, Robert Haas wrote: > On Fri, Jan 31, 2014 at 8:40 AM, Fujii Masao wrote: >> Yeah, I was thinking that, too. I'm not sure whether including log files >> in backup really increases the security risk, though. There are already >> very important data, i.e., database, i

Re: [HACKERS] pg_basebackup and pg_stat_tmp directory

2014-01-31 Thread Robert Haas
On Fri, Jan 31, 2014 at 8:40 AM, Fujii Masao wrote: > Yeah, I was thinking that, too. I'm not sure whether including log files > in backup really increases the security risk, though. There are already > very important data, i.e., database, in backups. Anyway, since > the amount of log files can be

Re: [HACKERS] pg_basebackup and pg_stat_tmp directory

2014-01-31 Thread Mitsumasa KONDO
2014-01-31 Fujii Masao : > On Fri, Jan 31, 2014 at 10:18 PM, Mitsumasa KONDO > wrote: > > 2014-01-31 Fujii Masao > >> > >> On Tue, Jan 28, 2014 at 5:51 PM, Magnus Hagander > >> wrote: > >> > On Tue, Jan 28, 2014 at 6:11 AM, Amit Kapila > > >> > wrote: > >> >> > >> >> On Tue, Jan 28, 2014 at 9:

Re: [HACKERS] pg_basebackup and pg_stat_tmp directory

2014-01-31 Thread Fujii Masao
On Fri, Jan 31, 2014 at 10:18 PM, Mitsumasa KONDO wrote: > 2014-01-31 Fujii Masao >> >> On Tue, Jan 28, 2014 at 5:51 PM, Magnus Hagander >> wrote: >> > On Tue, Jan 28, 2014 at 6:11 AM, Amit Kapila >> > wrote: >> >> >> >> On Tue, Jan 28, 2014 at 9:26 AM, Fujii Masao >> >> wrote: >> >> > Hi, >>

Re: [HACKERS] pg_basebackup and pg_stat_tmp directory

2014-01-31 Thread Mitsumasa KONDO
2014-01-31 Fujii Masao > On Tue, Jan 28, 2014 at 5:51 PM, Magnus Hagander > wrote: > > On Tue, Jan 28, 2014 at 6:11 AM, Amit Kapila > > wrote: > >> > >> On Tue, Jan 28, 2014 at 9:26 AM, Fujii Masao > >> wrote: > >> > Hi, > >> > > >> > The files in pg_stat_tmp directory don't need to be backed

Re: [HACKERS] pg_basebackup and pg_stat_tmp directory

2014-01-31 Thread Fujii Masao
On Tue, Jan 28, 2014 at 5:51 PM, Magnus Hagander wrote: > On Tue, Jan 28, 2014 at 6:11 AM, Amit Kapila > wrote: >> >> On Tue, Jan 28, 2014 at 9:26 AM, Fujii Masao >> wrote: >> > Hi, >> > >> > The files in pg_stat_tmp directory don't need to be backed up because >> > they are >> > basically reset

Re: [HACKERS] pg_basebackup and pg_stat_tmp directory

2014-01-28 Thread Magnus Hagander
On Tue, Jan 28, 2014 at 6:11 AM, Amit Kapila wrote: > On Tue, Jan 28, 2014 at 9:26 AM, Fujii Masao > wrote: > > Hi, > > > > The files in pg_stat_tmp directory don't need to be backed up because > they are > > basically reset at the archive recovery. So I think it's worth > > changing pg_basebacku

Re: [HACKERS] pg_basebackup and pg_stat_tmp directory

2014-01-27 Thread Amit Kapila
On Tue, Jan 28, 2014 at 9:26 AM, Fujii Masao wrote: > Hi, > > The files in pg_stat_tmp directory don't need to be backed up because they are > basically reset at the archive recovery. So I think it's worth > changing pg_basebackup > so that it skips any files in pg_stat_tmp directory. Thought? I

Re: [HACKERS] pg_basebackup and pg_stat_tmp directory

2014-01-27 Thread Fujii Masao
On Tue, Jan 28, 2014 at 1:08 PM, Michael Paquier wrote: > On Tue, Jan 28, 2014 at 12:56 PM, Fujii Masao wrote: >> Hi, >> >> The files in pg_stat_tmp directory don't need to be backed up because they >> are >> basically reset at the archive recovery. So I think it's worth >> changing pg_basebacku

Re: [HACKERS] pg_basebackup and pg_stat_tmp directory

2014-01-27 Thread Michael Paquier
On Tue, Jan 28, 2014 at 12:56 PM, Fujii Masao wrote: > Hi, > > The files in pg_stat_tmp directory don't need to be backed up because they are > basically reset at the archive recovery. So I think it's worth > changing pg_basebackup > so that it skips any files in pg_stat_tmp directory. Thought? Sk

[HACKERS] pg_basebackup and pg_stat_tmp directory

2014-01-27 Thread Fujii Masao
Hi, The files in pg_stat_tmp directory don't need to be backed up because they are basically reset at the archive recovery. So I think it's worth changing pg_basebackup so that it skips any files in pg_stat_tmp directory. Thought? Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing lis