Re: [HACKERS] pg_basebackup -R

2017-02-17 Thread Peter Eisentraut
On 2/15/17 10:52, Robert Haas wrote: > Let's wait and see if anybody else has an opinion. I imagine that, as > further libpq parameters are added, eventually this is going to get > long and annoying enough that we want to do something about it. But > we might not have reached that point just yet.

Re: [HACKERS] pg_basebackup -R

2017-02-15 Thread Robert Haas
On Tue, Feb 14, 2017 at 11:36 PM, Michael Paquier wrote: > On Wed, Feb 15, 2017 at 2:38 AM, Robert Haas wrote: >> On Thu, Feb 9, 2017 at 9:40 PM, Michael Paquier >> wrote: >>> In short, I'd like to think that we should just filter out those two >>> parameters by name and call it a day. Or introd

Re: [HACKERS] pg_basebackup -R

2017-02-14 Thread Michael Paquier
On Wed, Feb 15, 2017 at 2:38 AM, Robert Haas wrote: > On Thu, Feb 9, 2017 at 9:40 PM, Michael Paquier > wrote: >> In short, I'd like to think that we should just filter out those two >> parameters by name and call it a day. Or introduce an idea of value >> set for the environment by adding some k

Re: [HACKERS] pg_basebackup -R

2017-02-14 Thread Robert Haas
On Thu, Feb 9, 2017 at 9:40 PM, Michael Paquier wrote: > On Thu, Feb 9, 2017 at 8:17 PM, Amit Kapila wrote: >> +1. Sounds sensible thing to do. > > Hm. It seems to me that PGPASSFILE still needs to be treated as an > exception because it is set to $HOME/.pgpass without any value set in > PQconni

Re: [HACKERS] pg_basebackup -R

2017-02-09 Thread Michael Paquier
On Thu, Feb 9, 2017 at 8:17 PM, Amit Kapila wrote: > +1. Sounds sensible thing to do. Hm. It seems to me that PGPASSFILE still needs to be treated as an exception because it is set to $HOME/.pgpass without any value set in PQconninfoOption->compiled and it depends on the environment. Similar rul

Re: [HACKERS] pg_basebackup -R

2017-02-09 Thread Amit Kapila
On Wed, Feb 8, 2017 at 11:38 PM, Robert Haas wrote: > I just tried out pg_basebackup -R and got the following recovery.conf file: > > standby_mode = 'on' > primary_conninfo = 'user=rhaas passfile=''/home/rhaas/.pgpass'' > port=5432 sslmode=disable sslcompression=1 target_session_attrs=any' > > Thi

[HACKERS] pg_basebackup -R

2017-02-08 Thread Robert Haas
I just tried out pg_basebackup -R and got the following recovery.conf file: standby_mode = 'on' primary_conninfo = 'user=rhaas passfile=''/home/rhaas/.pgpass'' port=5432 sslmode=disable sslcompression=1 target_session_attrs=any' This seems fairly random to me. pg_basebackup explains: