Peter Eisentraut writes:
> On 3/1/17 11:21, Dagfinn Ilmari Mannsåker wrote:
>> diff --git a/src/pl/plperl/plc_perlboot.pl b/src/pl/plperl/plc_perlboot.pl
>> index 292c9101c9..b4212f5ab2 100644
>> --- a/src/pl/plperl/plc_perlboot.pl
>> +++ b/src/pl/plperl/plc_perlboot.pl
>> @@ -81,18 +81,15 @@ sub
On 3/23/17 11:58, Daniel Gustafsson wrote:
> Given the nitpick nature of the comments, bumping status to ready for
> committer.
Committed, with your changes.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
S
On 3/1/17 11:21, Dagfinn Ilmari Mannsåker wrote:
> diff --git a/src/pl/plperl/plc_perlboot.pl b/src/pl/plperl/plc_perlboot.pl
> index 292c9101c9..b4212f5ab2 100644
> --- a/src/pl/plperl/plc_perlboot.pl
> +++ b/src/pl/plperl/plc_perlboot.pl
> @@ -81,18 +81,15 @@ sub ::encode_array_constructor
>
> On 21 Mar 2017, at 19:20, David Steele wrote:
>
> On 3/6/17 12:02 PM, Dagfinn Ilmari Mannsåker wrote:
>> ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
>>
>>> Hi Peter,
>>>
>>> Peter Eisentraut writes:
>>>
I posted this about 18 months ago but then ran out of steam. [ ] Here
> On 21 Mar 2017, at 19:20, David Steele wrote:
>
> On 3/6/17 12:02 PM, Dagfinn Ilmari Mannsåker wrote:
>> ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
>>
>>> Hi Peter,
>>>
>>> Peter Eisentraut writes:
>>>
I posted this about 18 months ago but then ran out of steam. [ ] Here
Hi Daniel,
On 3/6/17 12:02 PM, Dagfinn Ilmari Mannsåker wrote:
ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
Hi Peter,
Peter Eisentraut writes:
I posted this about 18 months ago but then ran out of steam. [ ] Here
is an updated patch. The testing instructions below still apply.
Esp
ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
> Hi Peter,
>
> Peter Eisentraut writes:
>
>> I posted this about 18 months ago but then ran out of steam. [ ] Here
>> is an updated patch. The testing instructions below still apply.
>> Especially welcome would be ideas on how to address some
Hi Peter,
Peter Eisentraut writes:
> I posted this about 18 months ago but then ran out of steam. [ ] Here
> is an updated patch. The testing instructions below still apply.
> Especially welcome would be ideas on how to address some of the places
> I have marked with ## no critic.
Attached is
I posted this about 18 months ago but then ran out of steam. In the
meantime, some people have been going around doing various Perl code
cleanups in parts of the code, so it seems it makes sense to proceed
with this. We use "use strict" everywhere now, so some of the original
patch has gone away.
Hi,
On 2015-08-31 23:57:25 -0400, Peter Eisentraut wrote:
> We now have 80+ Perl files in our tree, and it's growing. Some of those
> files were originally written for Perl 4, and the coding styles and
> quality are quite, uh, divergent. So I figured it's time to clean up
> that code a bit. I r
On Tue, Sep 01, 2015 at 11:26:27AM -0400, Robert Haas wrote:
> On Tue, Sep 1, 2015 at 9:58 AM, Andrew Dunstan wrote:
> > On 08/31/2015 11:57 PM, Peter Eisentraut wrote:
> >> We now have 80+ Perl files in our tree, and it's growing. Some of those
> >> files were originally written for Perl 4, and
On Tue, Sep 1, 2015 at 11:58 AM, Mike Blackwell wrote:
> David wrote:
>> I believe there are ways to get perlcritic to keep quiet about things
>> we don't find relevant. Maybe that's a better way to use it.
>
> There are indeed. A .perlcriticrc file can suppress (or add) either
> individual rule
David wrote:
> I believe there are ways to get perlcritic to keep quiet about things
> we don't find relevant. Maybe that's a better way to use it.
>
There are indeed. A .perlcriticrc file can suppress (or add) either
individual rules or groups of rules. I use one to ignore the ones I
dis
On Tue, Sep 01, 2015 at 11:26:27AM -0400, Robert Haas wrote:
> On Tue, Sep 1, 2015 at 9:58 AM, Andrew Dunstan wrote:
> > On 08/31/2015 11:57 PM, Peter Eisentraut wrote:
> >> We now have 80+ Perl files in our tree, and it's growing. Some
> >> of those files were originally written for Perl 4, and
On Tue, Sep 1, 2015 at 9:58 AM, Andrew Dunstan wrote:
> On 08/31/2015 11:57 PM, Peter Eisentraut wrote:
>> We now have 80+ Perl files in our tree, and it's growing. Some of those
>> files were originally written for Perl 4, and the coding styles and
>> quality are quite, uh, divergent. So I figu
On 08/31/2015 11:57 PM, Peter Eisentraut wrote:
We now have 80+ Perl files in our tree, and it's growing. Some of those
files were originally written for Perl 4, and the coding styles and
quality are quite, uh, divergent. So I figured it's time to clean up
that code a bit. I ran perlcritic o
On Sep 1, 2015 6:25 AM, "Michael Paquier" wrote:
>
> On Tue, Sep 1, 2015 at 12:57 PM, Peter Eisentraut wrote:
> > We now have 80+ Perl files in our tree, and it's growing. Some of those
> > files were originally written for Perl 4, and the coding styles and
> > quality are quite, uh, divergent.
On Tue, Sep 1, 2015 at 12:57 PM, Peter Eisentraut wrote:
> We now have 80+ Perl files in our tree, and it's growing. Some of those
> files were originally written for Perl 4, and the coding styles and
> quality are quite, uh, divergent. So I figured it's time to clean up
> that code a bit. I ra
We now have 80+ Perl files in our tree, and it's growing. Some of those
files were originally written for Perl 4, and the coding styles and
quality are quite, uh, divergent. So I figured it's time to clean up
that code a bit. I ran perlcritic over the tree and cleaned up all the
warnings at leve
19 matches
Mail list logo
