Re: [HACKERS] patch for xidin

2015-04-29 Thread Robert Haas
On Fri, Apr 17, 2015 at 10:27 AM, Tom Lane wrote: >> The patch will correct it. I have justly copy some code of 'OID'. Whether we >> need to extract the common code? > > This seems like an awful lot of code to solve a problem that will never > occur in practice. It does seem like an awful lot of

Re: [HACKERS] patch for xidin

2015-04-17 Thread Tom Lane
"Zhang Zq" writes: >The implements of 'xidin' use only ¡®strtoul¡¯ to cast from string to > xid. So in some cases, may cause confusion, for example, > The sql 'select c1 from test where xmin='abc' can be executed. and sometimes > will make mistakes, I want to query "select c1 from test

[HACKERS] patch for xidin

2015-04-17 Thread Zhang Zq
hi, The implements of 'xidin' use only ‘strtoul’ to cast from string to xid. So in some cases, may cause confusion, for example, The sql 'select c1 from test where xmin='abc' can be executed. and sometimes will make mistakes, I want to query "select c1 from test where xmin='0x10'" ,but write