2014-03-04 8:55 GMT+01:00 Pavel Stehule :
>
>
>
> 2014-03-03 18:18 GMT+01:00 Alvaro Herrera :
>
> Pavel Stehule escribió:
>> > This patch has redesigned implementation --if-exists for pg_dumpall.
>> Now it
>> > is not propagated to pg_dump, but used on pg_dumpall level.
>>
>> Seems sane, thanks.
>
2014-03-03 18:18 GMT+01:00 Alvaro Herrera :
> Pavel Stehule escribió:
> > This patch has redesigned implementation --if-exists for pg_dumpall. Now
> it
> > is not propagated to pg_dump, but used on pg_dumpall level.
>
> Seems sane, thanks.
>
>
> BTW after this patch, I still don't see an error-fre
Pavel Stehule escribió:
> This patch has redesigned implementation --if-exists for pg_dumpall. Now it
> is not propagated to pg_dump, but used on pg_dumpall level.
Seems sane, thanks.
BTW after this patch, I still don't see an error-free output from
restoring a database on top of itself. One pr
This patch has redesigned implementation --if-exists for pg_dumpall. Now it
is not propagated to pg_dump, but used on pg_dumpall level.
Regards
Pavel
2014-02-28 23:18 GMT+01:00 Pavel Stehule :
>
>
>
> 2014-02-28 23:13 GMT+01:00 Pavel Stehule :
>
> Hi
>>
>>
>>> However, I don't think this is be
2014-02-28 23:13 GMT+01:00 Pavel Stehule :
> Hi
>
>
>> However, I don't think this is behaving sanely in pg_dumpall. AFAICT,
>> pg_dumpall does not pass --clean to pg_dump (in other words it only
>> emits DROP for the global objects, not the objects contained inside
>> databases), so passing --if
Hi
> However, I don't think this is behaving sanely in pg_dumpall. AFAICT,
> pg_dumpall does not pass --clean to pg_dump (in other words it only
> emits DROP for the global objects, not the objects contained inside
> databases), so passing --if-exists results in failures. Therefore I
> think th
2014-02-28 19:31 GMT+01:00 Alvaro Herrera :
> Pavel Stehule escribió:
>
> > It is irony, so this is death code - it is not used now. So I removed it
> > from patch.
> >
> > Reduced, fixed patch attached + used tests
>
> Nice, thanks.
>
> Here's a new version in which I reworded some comments and d
Pavel Stehule escribió:
> It is irony, so this is death code - it is not used now. So I removed it
> from patch.
>
> Reduced, fixed patch attached + used tests
Nice, thanks.
Here's a new version in which I reworded some comments and docs, and
also inverted the sense of some if/else so that the
Hello
2014-02-17 22:14 GMT+01:00 Pavel Stehule :
> Hello
>
>
> 2014-02-17 18:10 GMT+01:00 Alvaro Herrera :
>
> Jeevan Chalke escribió:
>>
>> I don't understand this code. (Well, it's pg_dump.) Or maybe I do
>> understand it, and it's not doing what you think it's doing. I mean, in
>> this par
On Mon, Feb 17, 2014 at 7:43 PM, Alvaro Herrera wrote:
> Jeevan Chalke escribió:
>
> > If yes, then in my latest attached patch, these lines are NOT AT ALL
> there.
> > I have informed on my comment that I have fixed these in my version of
> > patch,
> > but still you got unstable build. NOT sure
Pavel Stehule escribió:
> 2014-02-17 18:10 GMT+01:00 Alvaro Herrera :
> > Maybe I am mistaken and the te->dropStmt already contains the IF EXISTS
> > bit for some reason; but if so I don't know why that is. Care to
> > explain?
>
> pg_restore is available to read plain dump produced by pg_dump
Hello
2014-02-17 18:10 GMT+01:00 Alvaro Herrera :
> Jeevan Chalke escribió:
>
> I don't understand this code. (Well, it's pg_dump.) Or maybe I do
> understand it, and it's not doing what you think it's doing. I mean, in
> this part:
>
> > diff --git a/src/bin/pg_dump/pg_backup_archiver.c
> b/
Jeevan Chalke escribió:
I don't understand this code. (Well, it's pg_dump.) Or maybe I do
understand it, and it's not doing what you think it's doing. I mean, in
this part:
> diff --git a/src/bin/pg_dump/pg_backup_archiver.c
> b/src/bin/pg_dump/pg_backup_archiver.c
> index 7fc0288..c08a0d3 10
Jeevan Chalke escribió:
> If yes, then in my latest attached patch, these lines are NOT AT ALL there.
> I have informed on my comment that I have fixed these in my version of
> patch,
> but still you got unstable build. NOT sure how. Seems like you are applying
> wrong patch.
>
> Will you please
Hi Peter,
I am not sure why you getting build unstable due to white-space errors.
Are you referring to these line ?
*11:25:01* src/bin/pg_dump/pg_backup_archiver.c:477: indent with
spaces.*11:25:01* +
2014-01-30 Jeevan Chalke :
> OK.
>
> Assigned it to committer.
>
> Thanks for the hard work.
>
Thank you for review
Pavel
>
>
> On Thu, Jan 30, 2014 at 6:16 PM, Pavel Stehule wrote:
>
>> Hello
>>
>> All is ok
>>
>> Thank you
>>
>> Pavel
>>
>
> --
> Jeevan B Chalke
> Principal Software Engineer
OK.
Assigned it to committer.
Thanks for the hard work.
On Thu, Jan 30, 2014 at 6:16 PM, Pavel Stehule wrote:
> Hello
>
> All is ok
>
> Thank you
>
> Pavel
>
--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Hello
All is ok
Thank you
Pavel
2014-01-30 Jeevan Chalke :
> Hi Pavel,
>
> Now patch looks good to me and I think it is in good shape to pass it on to
> the committer as well.
>
> However, I have
> - Tweaked few comments
> - Removed white-space errors
> - Fixed typos
> - Fixed indentation
>
>
Hi Pavel,
Now patch looks good to me and I think it is in good shape to pass it on to
the committer as well.
However, I have
- Tweaked few comments
- Removed white-space errors
- Fixed typos
- Fixed indentation
Attached patch with my changes. However entire design and code logic is
untouched.
P
Hello
patch with updated comment
regards
Pavel
2014-01-30 Jeevan Chalke :
> Hi Pavel,
>
> it should be fixed by
>>> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=b152c6cd0de1827ba58756e24e18110cf902182acommit
>>>
>>
> Ok. Good.
> Sorry I didn't update my sources. Done no
Hi Pavel,
it should be fixed by
>> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=b152c6cd0de1827ba58756e24e18110cf902182acommit
>>
>
Ok. Good.
Sorry I didn't update my sources. Done now. Thanks
>
>>
>>>
>>> Also, I didn't quite understand these lines of comments:
>>>
>>>
2014-01-29 Pavel Stehule
>
>
>
> 2014-01-29 Jeevan Chalke
>
> Hi Pavel,
>>
>> Now the patch looks good to me. However when I try to restore your own
>> sql file's dump, I get following errors:
>>
>> pg_restore: [archiver (db)] could not execute query: ERROR: relation
>> "public.emp" does not ex
2014-01-29 Jeevan Chalke
> Hi Pavel,
>
> Now the patch looks good to me. However when I try to restore your own sql
> file's dump, I get following errors:
>
> pg_restore: [archiver (db)] could not execute query: ERROR: relation
> "public.emp" does not exist
> Command was: DROP TRIGGER IF EXI
Hi Pavel,
Now the patch looks good to me. However when I try to restore your own sql
file's dump, I get following errors:
pg_restore: [archiver (db)] could not execute query: ERROR: relation
"public.emp" does not exist
Command was: DROP TRIGGER IF EXISTS emp_insert_trigger ON public.emp;
pg
Hello
Second update - I reduced patch by removing not necessary changes.
Attached tests and Makefile
Now --if-exists option is fully consistent with -c option
With some free time I plan to enhance test script about more object types -
now It contains almost all usual types.
Regards
Pavel
Tomorrow I'll send updated version
Regards
Pavel
2014/1/21 Jeevan Chalke
> Hi Pavel,
>
> Consider following test scenario:
>
> mydb=# \d emp
> Table "public.emp"
> Column | Type | Modifiers
> +-+---
> empno | integer | not null
> deptno | integer |
> enam
Hi Pavel,
Consider following test scenario:
mydb=# \d emp
Table "public.emp"
Column | Type | Modifiers
+-+---
empno | integer | not null
deptno | integer |
ename | text|
Indexes:
"emp_pkey" PRIMARY KEY, btree (empno)
Foreign-key constraints:
"emp
Hello
2014/1/16 Jeevan Chalke
> Hi Pavel,
>
> I have reviewed the patch and here are my concerns and notes:
>
> POSITIVES:
> ---
> 1. Patch applies with some white-space errors.
> 2. make / make install / make check is smooth. No issues as such.
> 3. Feature looks good as well.
> 4. NO concern
Hi Pavel,
I have reviewed the patch and here are my concerns and notes:
POSITIVES:
---
1. Patch applies with some white-space errors.
2. make / make install / make check is smooth. No issues as such.
3. Feature looks good as well.
4. NO concern on overall design.
5. Good work.
NEGATIVES:
---
H
Hello
next version
pg_restore knows --if-exists option now
Regards
Pavel Stehule
2013/12/13 Pavel Stehule
> Hello
>
> I am sending a rebased patch.
>
> Now dump generated with --if-exists option is readable by pg_restore
>
> Regards
>
> Pavel
>
commit 7c79aa77ccf53252bac8ce2302a7a0f7a1942e9
Hello
I am sending a rebased patch.
Now dump generated with --if-exists option is readable by pg_restore
Regards
Pavel
commit 19f21165343b1aaa6cc21d381b84e3c0ce6e3b46
Author: Pavel Stehule
Date: Fri Dec 13 14:02:46 2013 +0100
--if-exists option for pg_dump
diff --git a/doc/src/sgml/ref
31 matches
Mail list logo
