Re: [HACKERS] patch: enhanced get diagnostics statement 2

2011-07-18 Thread Tom Lane
Pavel Stehule writes: > 2011/7/14 Alvaro Herrera : >> Thanks ... I expect you're going to resubmit the patch based on David's >> last version and my comments? > yes, see a attachment Applied with some editorial adjustments. regards, tom lane -- Sent via pgsql-hackers m

Re: [HACKERS] patch: enhanced get diagnostics statement 2

2011-07-15 Thread Pavel Stehule
Hello 2011/7/14 Alvaro Herrera : > Excerpts from Pavel Stehule's message of jue jul 14 16:25:56 -0400 2011: >> 2011/7/14 Alvaro Herrera : >> > A couple items for this patch: > >> it is good idea > > Thanks ... I expect you're going to resubmit the patch based on David's > last version and my comme

Re: [HACKERS] patch: enhanced get diagnostics statement 2

2011-07-14 Thread Pavel Stehule
2011/7/14 Alvaro Herrera : > Excerpts from Pavel Stehule's message of jue jul 14 16:25:56 -0400 2011: >> 2011/7/14 Alvaro Herrera : >> > A couple items for this patch: > >> it is good idea > > Thanks ... I expect you're going to resubmit the patch based on David's > last version and my comments? >

Re: [HACKERS] patch: enhanced get diagnostics statement 2

2011-07-14 Thread Alvaro Herrera
Excerpts from Pavel Stehule's message of jue jul 14 16:25:56 -0400 2011: > 2011/7/14 Alvaro Herrera : > > A couple items for this patch: > it is good idea Thanks ... I expect you're going to resubmit the patch based on David's last version and my comments? -- Álvaro Herrera The PostgreSQL Comp

Re: [HACKERS] patch: enhanced get diagnostics statement 2

2011-07-14 Thread Pavel Stehule
2011/7/14 Alvaro Herrera : > A couple items for this patch: > > The docs state that the variable to receive each diagnostic value needs > to be "of the right data type" but fails to specify what it is.  I think > it'd be good to turn that into a table with three > columns: name, type, description.

Re: [HACKERS] patch: enhanced get diagnostics statement 2

2011-07-14 Thread Alvaro Herrera
A couple items for this patch: The docs state that the variable to receive each diagnostic value needs to be "of the right data type" but fails to specify what it is. I think it'd be good to turn that into a table with three columns: name, type, description. This seems poor style: +

Re: [HACKERS] patch: enhanced get diagnostics statement 2

2011-07-10 Thread David E. Wheeler
On Jul 7, 2011, at 12:30 AM, Pavel Stehule wrote: > thank you very much for review. I thank you, too, Hanada-san. I was assigned to review this patch, but you beat me to it. So now I'll do the follow-up review. > I cleaned patch and merged your documentation patch > > I hope, this is all - a l

Re: [HACKERS] patch: enhanced get diagnostics statement 2

2011-07-07 Thread Pavel Stehule
Hello thank you very much for review. I cleaned patch and merged your documentation patch I hope, this is all - a language correction should do some native speaker Regards Pavel Stehule 2011/7/6 Shigeru Hanada : > (2011/06/02 17:39), Pavel Stehule wrote: >> This patch enhances a GET DIAGNOSTI

Re: [HACKERS] patch: enhanced get diagnostics statement 2

2011-07-06 Thread Shigeru Hanada
(2011/06/02 17:39), Pavel Stehule wrote: > This patch enhances a GET DIAGNOSTICS statement functionality. It adds > a possibility of access to exception's data. These data are stored on > stack when exception's handler is activated - and these data are > access-able everywhere inside handler. It ha

[HACKERS] patch: enhanced get diagnostics statement 2

2011-06-02 Thread Pavel Stehule
Hello This patch enhances a GET DIAGNOSTICS statement functionality. It adds a possibility of access to exception's data. These data are stored on stack when exception's handler is activated - and these data are access-able everywhere inside handler. It has a different behave (the content is immut