Re: [HACKERS] parser handling of large object OIDs

2010-06-10 Thread Robert Haas
On Wed, Jun 9, 2010 at 10:26 PM, Tom Lane wrote: > Robert Haas writes: >> On Wed, Jun 9, 2010 at 5:02 PM, Robert Haas wrote: >>> I believe that the comment code is probably right, because I think >>> IConst can only handle values < 2^31, whereas OIDs can be as large as >>> 2^32-1. > >> I investi

Re: [HACKERS] parser handling of large object OIDs

2010-06-09 Thread Tom Lane
Robert Haas writes: > On Wed, Jun 9, 2010 at 5:02 PM, Robert Haas wrote: >> I believe that the comment code is probably right, because I think >> IConst can only handle values < 2^31, whereas OIDs can be as large as >> 2^32-1. > I investigated this a little more and the above analysis turns out

Re: [HACKERS] parser handling of large object OIDs

2010-06-09 Thread Robert Haas
On Wed, Jun 9, 2010 at 5:02 PM, Robert Haas wrote: > I believe that the comment code is probably right, because I think > IConst can only handle values < 2^31, whereas OIDs can be as large as > 2^32-1. I investigated this a little more and the above analysis turns out to be correct. ALTER LARGE

[HACKERS] parser handling of large object OIDs

2010-06-09 Thread Robert Haas
gram.y treats large object identifiers inconsistently. The privileges stuff treats them as IConst: | LARGE_P OBJECT_P Iconst_list { PrivTarget *n = (PrivTarget *) palloc(sizeof(PrivTarget)); n->targtype = ACL_TARGET_OBJECT;