Re: [HACKERS] parallel explain analyze support not exercised

2017-04-06 Thread Andres Freund
On 2017-04-06 17:33:49 -0400, Tom Lane wrote: > Andres Freund writes: > > I guess we'll have to see. My personal conclusion is that greater > > coverage of parallelism is worth some very minor config trouble for > > people doing installcheck against clusters with non-default config. > > The build

Re: [HACKERS] parallel explain analyze support not exercised

2017-04-06 Thread Tom Lane
Andres Freund writes: > I guess we'll have to see. My personal conclusion is that greater > coverage of parallelism is worth some very minor config trouble for > people doing installcheck against clusters with non-default config. The buildfarm seems entirely unwilling to play along.

Re: [HACKERS] parallel explain analyze support not exercised

2017-04-06 Thread Andres Freund
Hi, On 2017-04-03 17:11:33 -0400, Robert Haas wrote: > On Mon, Apr 3, 2017 at 3:31 PM, Andres Freund wrote: > >> If this is 'make check', then we should have 8 parallel workers > >> allowed, so if we only do one of these at a time, then I think we're > >> OK. But if somebody changes that configu

Re: [HACKERS] parallel explain analyze support not exercised

2017-04-03 Thread Robert Haas
On Mon, Apr 3, 2017 at 3:31 PM, Andres Freund wrote: >> If this is 'make check', then we should have 8 parallel workers >> allowed, so if we only do one of these at a time, then I think we're >> OK. But if somebody changes that configuration setting or if it's >> 'make installcheck', then the con

Re: [HACKERS] parallel explain analyze support not exercised

2017-04-03 Thread Andres Freund
On 2017-04-03 15:13:13 -0400, Robert Haas wrote: > On Mon, Apr 3, 2017 at 1:53 PM, Andres Freund wrote: > >> Please find the attached for the same. > > > >> +-- to increase the parallel query test coverage > >> +EXPLAIN (analyze, timing off, summary off, costs off) SELECT * FROM tenk1; > >> +

Re: [HACKERS] parallel explain analyze support not exercised

2017-04-03 Thread Robert Haas
On Mon, Apr 3, 2017 at 1:53 PM, Andres Freund wrote: >> Please find the attached for the same. > >> +-- to increase the parallel query test coverage >> +EXPLAIN (analyze, timing off, summary off, costs off) SELECT * FROM tenk1; >> + QUERY PLAN >> +--

Re: [HACKERS] parallel explain analyze support not exercised

2017-04-03 Thread Andres Freund
On 2017-04-03 10:26:27 +0530, Rafia Sabih wrote: > On Sat, Apr 1, 2017 at 12:25 AM, Andres Freund wrote: > > Hi, > > > > As visible in [1], the explain analyze codepaths of parallel query isn't > > exercised in the tests. That used to be not entirely trivial if the > > output was to be displayed

Re: [HACKERS] parallel explain analyze support not exercised

2017-04-02 Thread Rafia Sabih
On Sat, Apr 1, 2017 at 12:25 AM, Andres Freund wrote: > Hi, > > As visible in [1], the explain analyze codepaths of parallel query isn't > exercised in the tests. That used to be not entirely trivial if the > output was to be displayed (due to timing), but we should be able to do > that now that

[HACKERS] parallel explain analyze support not exercised

2017-03-31 Thread Andres Freund
Hi, As visible in [1], the explain analyze codepaths of parallel query isn't exercised in the tests. That used to be not entirely trivial if the output was to be displayed (due to timing), but we should be able to do that now that we have the SUMMARY option. E.g. SET max_parallel_workers = 0; EX