Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

On 08/22/2014 11:35 AM, Amit Kapila wrote: On Fri, Aug 22, 2014 at 1:00 PM, Heikki Linnakangas wrote: On 08/22/2014 07:08 AM, Amit Kapila wrote: Today morning, I realised that there is one problem with the patch I sent yesterday and the problem is that incase user has not given -T option, it w

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

On Fri, Aug 22, 2014 at 1:00 PM, Heikki Linnakangas wrote: > On 08/22/2014 07:08 AM, Amit Kapila wrote: >> Today morning, I realised that there is one problem with the >> patch I sent yesterday and the problem is that incase user >> has not given -T option, it will not be able to create the symlin

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

On 08/22/2014 07:08 AM, Amit Kapila wrote: On Thu, Aug 21, 2014 at 3:44 PM, Amit Kapila wrote: On Tue, Aug 19, 2014 at 9:51 AM, Amit Kapila wrote: On Mon, Aug 18, 2014 at 7:50 PM, Heikki Linnakangas < hlinnakan...@vmware.com> wrote: Wouldn't it make a lot more sense to create it correctly

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

On Thu, Aug 21, 2014 at 3:44 PM, Amit Kapila wrote: > > On Tue, Aug 19, 2014 at 9:51 AM, Amit Kapila wrote: > > On Mon, Aug 18, 2014 at 7:50 PM, Heikki Linnakangas < hlinnakan...@vmware.com> wrote: > > >Wouldn't it make a lot more sense to create it correctly in the first place? > > > > Looking a

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

On Tue, Aug 19, 2014 at 9:51 AM, Amit Kapila wrote: > On Mon, Aug 18, 2014 at 7:50 PM, Heikki Linnakangas < hlinnakan...@vmware.com> wrote: > >Wouldn't it make a lot more sense to create it correctly in the first place? > > Looking at the code, I think it is very well possible to create > it corre

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

On Mon, Aug 18, 2014 at 7:50 PM, Heikki Linnakangas wrote: > > I didn't follow the original discussions, but now that I look at this I have to wonder: > > Why does pg_basebackup -T create the symlink pointing to the wrong location in the first place, only to fix it later? Good question. >Wouldn'

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

I didn't follow the original discussions, but now that I look at this I have to wonder: Why does pg_basebackup -T create the symlink pointing to the wrong location in the first place, only to fix it later? Wouldn't it make a lot more sense to create it correctly in the first place? - Heikki

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

On Mon, Aug 18, 2014 at 11:51 AM, Amit Kapila wrote: > On Mon, Aug 18, 2014 at 7:08 AM, Michael Paquier > wrote: >> >> On Mon, Aug 18, 2014 at 9:37 AM, Peter Eisentraut wrote: >> > It's not ready for committer if the current patch does not apply. >> FWIW, the latest version sent by Amit here app

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

On Mon, Aug 18, 2014 at 7:08 AM, Michael Paquier wrote: > > On Mon, Aug 18, 2014 at 9:37 AM, Peter Eisentraut wrote: > > It's not ready for committer if the current patch does not apply. > FWIW, the latest version sent by Amit here applies correctly: > http://www.postgresql.org/message-id/caa4ek1

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

On Mon, Aug 18, 2014 at 9:37 AM, Peter Eisentraut wrote: > It's not ready for committer if the current patch does not apply. FWIW, the latest version sent by Amit here applies correctly: http://www.postgresql.org/message-id/caa4ek1+cc9rb1s9q4+nsokfas1yufvfgfxuhxy_6wlbq1re...@mail.gmail.com I haven

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

On 8/16/14 8:46 AM, Amit Kapila wrote: > On Fri, Aug 15, 2014 at 1:03 PM, MauMau > wrote: >> >> Thank you. The code looks correct. I confirmed that the > pg_basebackup could relocate the tablespace directory on Windows. >> >> I marked this patch as ready for committer

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

On Fri, Aug 15, 2014 at 1:03 PM, MauMau wrote: > > Thank you. The code looks correct. I confirmed that the pg_basebackup could relocate the tablespace directory on Windows. > > I marked this patch as ready for committer. Thanks for the review. With Regards, Amit Kapila. EnterpriseDB: http://ww

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

Thank you. The code looks correct. I confirmed that the pg_basebackup could relocate the tablespace directory on Windows. I marked this patch as ready for committer. Regards MauMau -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

On Wed, Aug 13, 2014 at 9:20 PM, MauMau wrote: > > From: "Amit Kapila" > >> During my recent work on pg_basebackup, I noticed that >> -T option doesn't seem to work on Windows. >> The reason for the same is that while updating symlinks >> it doesn't consider that on Windows, junction points can >

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

On Thu, Aug 14, 2014 at 12:50 AM, MauMau wrote: > The code change appears correct, but the patch application failed against > the latest source code. I don't know why. Could you confirm this? > > patching file src/bin/pg_basebackup/pg_basebackup.c > Hunk #1 FAILED at 1119. > 1 out of 1 hunk FAIL

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

From: "Amit Kapila" During my recent work on pg_basebackup, I noticed that -T option doesn't seem to work on Windows. The reason for the same is that while updating symlinks it doesn't consider that on Windows, junction points can be directories due to which it is not able to update the symlink

[HACKERS] option -T in pg_basebackup doesn't work on windows

During my recent work on pg_basebackup, I noticed that -T option doesn't seem to work on Windows. The reason for the same is that while updating symlinks it doesn't consider that on Windows, junction points can be directories due to which it is not able to update the symlink location. Fix is to mak