Re: [HACKERS] note about syntax for fillfactor patch

2006-07-02 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > # CREATE TABLE test1 (i int) WITH (oids=0); > CREATE TABLE > # CREATE TABLE test2 (i int) WITH (oids=false); > ERROR: syntax error at or near "false" > LINE 1: CREATE TABLE test2 (i int) WITH (oids=false); >

Re: [HACKERS] note about syntax for fillfactor patch

2006-07-02 Thread ITAGAKI Takahiro
Tom Lane <[EMAIL PROTECTED]> wrote: > I propose that we change the syntax to be > > WITH OIDS > | WITHOUT OIDS > | WITH (definition) > | /*EMPTY*/ > > and say that if you want to specify both OIDS and another option you > have to write "oids" or "oids=false" in the defini

Re: [HACKERS] note about syntax for fillfactor patch

2006-07-02 Thread Simon Riggs
On Sun, 2006-07-02 at 12:06 -0400, Tom Lane wrote: > I propose that we change the syntax to be > > WITH OIDS > | WITHOUT OIDS > | WITH (definition) > | /*EMPTY*/ > > and say that if you want to specify both OIDS and another option you > have to write "oids" or "oids=false

Re: [HACKERS] note about syntax for fillfactor patch

2006-07-02 Thread Bruce Momjian
Tom Lane wrote: > The latter seems seriously grotty: it forces the user to remember an Agreed. > I propose that we change the syntax to be > > WITH OIDS > | WITHOUT OIDS > | WITH (definition) > | /*EMPTY*/ > > and say that if you want to specify both OIDS and another opt

[HACKERS] note about syntax for fillfactor patch

2006-07-02 Thread Tom Lane
I see that the just-applied fillfactor patch has changed the syntax for CREATE TABLE to replace OptWithOids: WITH OIDS{ $$ = MUST_HAVE_OIDS; } | WITHOUT OIDS { $$ = MUST_NOT_HAVE_OIDS; } | /*EMPTY*/