Re: [HACKERS] mingw format warnings

2011-01-28 Thread Andrew Dunstan
On 01/28/2011 05:34 PM, Tom Lane wrote: Andrew Dunstan writes: On 01/28/2011 03:11 PM, Tom Lane wrote: Are any of them substantive, or are they all about %m ? [andrew@aurelia ]$ grep 'warning.*format' frogmouth-make*.log | sed 's/.*warning:/warning:/' | sort | uniq -c I'd say a lot of tho

Re: [HACKERS] mingw format warnings

2011-01-28 Thread Andrew Dunstan
On 01/28/2011 02:39 PM, Peter Eisentraut wrote: On fre, 2011-01-28 at 14:12 -0500, Andrew Dunstan wrote: We have had format warnings in mingw builds for years, and it doesn't look like we're ever going to do anything about them. Can we just add -Wno-format to the CFLAGS for Mingw and be done w

Re: [HACKERS] mingw format warnings

2011-01-28 Thread Tom Lane
Andrew Dunstan writes: > On 01/28/2011 03:11 PM, Tom Lane wrote: >> Are any of them substantive, or are they all about %m ? > [andrew@aurelia ]$ grep 'warning.*format' frogmouth-make*.log | sed > 's/.*warning:/warning:/' | sort | uniq -c I'd say a lot of those probably need attention. It migh

Re: [HACKERS] mingw format warnings

2011-01-28 Thread Andrew Dunstan
On 01/28/2011 03:11 PM, Tom Lane wrote: Andrew Dunstan writes: We have had format warnings in mingw builds for years, and it doesn't look like we're ever going to do anything about them. Can we just add -Wno-format to the CFLAGS for Mingw and be done with them? Are any of them substantive, o

Re: [HACKERS] mingw format warnings

2011-01-28 Thread Tom Lane
Andrew Dunstan writes: > We have had format warnings in mingw builds for years, and it doesn't > look like we're ever going to do anything about them. Can we just add > -Wno-format to the CFLAGS for Mingw and be done with them? Are any of them substantive, or are they all about %m ?

Re: [HACKERS] mingw format warnings

2011-01-28 Thread Peter Eisentraut
On fre, 2011-01-28 at 14:12 -0500, Andrew Dunstan wrote: > We have had format warnings in mingw builds for years, and it doesn't > look like we're ever going to do anything about them. Can we just add > -Wno-format to the CFLAGS for Mingw and be done with them? I wasn't aware of this issue, but

[HACKERS] mingw format warnings

2011-01-28 Thread Andrew Dunstan
We have had format warnings in mingw builds for years, and it doesn't look like we're ever going to do anything about them. Can we just add -Wno-format to the CFLAGS for Mingw and be done with them? cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make